Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SG-225] Reserve Auctions #283

Merged
merged 5 commits into from
Apr 21, 2023
Merged

[SG-225] Reserve Auctions #283

merged 5 commits into from
Apr 21, 2023

Conversation

tasiov
Copy link
Contributor

@tasiov tasiov commented Apr 21, 2023

No description provided.

jhernandezb and others added 2 commits April 21, 2023 10:47
@jhernandezb @tasiov
update stargaze version (#13)
ad06508
@tasiov @shanev
@spoo-bar @yubrew
Tasiov/sg 225 reserve auction updates (#14)
50877ae 
* Add initial reserve auction code

* Add README

* Update README

* Update README

* Update README

* Update README

* Update README

* Update README

* Update README

* Add state

* Add messages

* Create auction

* Create bid

* Settle auction

* Fix start time

* Add end_time

* Update and cancel

* Settle auction

* Change queue storage type

* Settle auctions

* Refactor

* Add trading fees

* Fix query

* Use workspace

* Add packages directory

* Implement controller

* Royalty payout controller

* Use royalty payout from sg721 instead

* Transfer NFT helper

* Rename to common

* Fix warnings

* Use payout helpers

* Protocol fee

* Royalties

* Fix deps mut

* Refactor payout

* Fix helpers

* Add queries

* Create bid: take 2

* Update Auction type

* Update lockfile

* Update lockfile

* Update to new launchpad version

* Add packages directory

* Update sg-std dep (in launchpad repo)

* Fix warnings

* Check approval

* Fix migrate test

* Fix update reserve price

* Fix reserver price logic

* Update settle auction

* Remove commented code

* adding sudo entrypoint & msg type

* hooking sudomsg to end_block()

* update version for sg721, sg721-base

* add royalty payout

* add unit tests

* init test passes

* use test suite file structure

* add setup and sg5 package

* create auction

* test reserve price, cancel

* add TODOs for potential issues

* better var name

* check accounting after auction settled

* add todo's

* update readme

* Add initial reserve auction code

* Add README

* Update README

* Update README

* Update README

* Update README

* Update README

* Update README

* Update README

* Add state

* Add messages

* Create auction

* Create bid

* Settle auction

* Fix start time

* Add end_time

* Update and cancel

* Settle auction

* Change queue storage type

* Settle auctions

* Refactor

* Add trading fees

* Fix query

* Use workspace

* Add packages directory

* Implement controller

* Royalty payout controller

* Use royalty payout from sg721 instead

* Transfer NFT helper

* Rename to common

* Fix warnings

* Use payout helpers

* Protocol fee

* Royalties

* Fix deps mut

* Refactor payout

* Fix helpers

* Add queries

* Create bid: take 2

* Update Auction type

* Update lockfile

* Update lockfile

* Update to new launchpad version

* Add packages directory

* Update sg-std dep (in launchpad repo)

* Fix warnings

* Check approval

* Fix migrate test

* Fix update reserve price

* Fix reserver price logic

* Update settle auction

* Remove commented code

* adding sudo entrypoint & msg type

* hooking sudomsg to end_block()

* reserve auctions types for test suite

* test if auction already exists

* accounting for settling auction

* refactor for lint

* test create auction fee

* fix bids for potential overflow

* fix create bid amount comparison

* adding begin blocker callbacks to contract

* update code comments

* [SG-713][SG-714] Escrow NFT upon auction creation, refund NFT upon auction cancellation

* Reserve auctions refactor checkpoint

* Writing tests, checkpoint

* Writing tests, checkpoint 2

* Finish writing base unit tests

* Resolve conflicts

* Lint, schema, cleanup PR

* Cleanup deps

* Update README.md

* Read trading_fee_percent from marketplace contract

* Add sudo message for updating params

* Add extended duration test

* Add query tests

* Add sudo begin and end block tests

* Add sudo update params test

* Update schema

* Update codecov.yml

* Update coverage.yml

* Update response events

* Change min_bid_increment to be percentage based

* Ensure create auction fee is fair burned

* Add nonpayables

* Add config var max_auctions_to_settle_per_block

* Update contracts/reserve-auction/Cargo.toml

* Remove schema raw files

* Adjust get_min_bid

---------

Co-authored-by: Shane Vitarana <shanev@gmail.com>
Co-authored-by: Spoorthi <spoorthi_s@ymail.com>
Co-authored-by: John Y <j@publicawesome.com>
Co-authored-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com>
@linear
Copy link

linear bot commented Apr 21, 2023

SG-225 Implement reserve auctions

@codecov
Copy link

codecov bot commented Apr 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 91.40% and project coverage change: -4.41 ⚠️

Comparison is base (e19b7d7) 96.78% compared to head (1651084) 92.37%.

❗ Current head 1651084 differs from pull request most recent head d46994f. Consider uploading reports for the commit d46994f to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
- Coverage   96.78%   92.37%   -4.41%     
==========================================
  Files          22       21       -1     
  Lines        3916     1784    -2132     
==========================================
- Hits         3790     1648    -2142     
- Misses        126      136      +10
Impacted Files Coverage Δ
contracts/marketplace/src/query.rs 91.27% <ø> (ø)
contracts/marketplace/src/sudo.rs 97.08% <ø> (ø)
contracts/reserve-auction/src/bin/schema.rs 0.00% <0.00%> (ø)
contracts/reserve-auction/src/helpers.rs 67.16% <67.16%> (ø)
packages/common/src/lib.rs 87.80% <87.80%> (ø)
contracts/reserve-auction/src/state.rs 90.90% <90.90%> (ø)
contracts/reserve-auction/src/query.rs 94.54% <94.54%> (ø)
contracts/reserve-auction/src/execute.rs 100.00% <100.00%> (ø)
contracts/reserve-auction/src/instantiate.rs 100.00% <100.00%> (ø)
contracts/reserve-auction/src/sudo.rs 100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tasiov tasiov changed the title Tasiov/sg 225 reserve auction marketplace main [SG-225] Reserve Auctions Apr 21, 2023
@tasiov tasiov force-pushed the tasiov/sg-225-reserve-auction-marketplace-main branch from ea545c0 to 4843e5b Compare April 21, 2023 15:46
@yubrew yubrew self-requested a review April 21, 2023 15:52
@tasiov tasiov force-pushed the tasiov/sg-225-reserve-auction-marketplace-main branch from 4843e5b to 1651084 Compare April 21, 2023 15:53
@tasiov tasiov force-pushed the tasiov/sg-225-reserve-auction-marketplace-main branch from 1651084 to d46994f Compare April 21, 2023 16:21
@tasiov tasiov added this pull request to the merge queue Apr 21, 2023
Merged via the queue into main with commit c7f471f Apr 21, 2023
@shanev shanev deleted the tasiov/sg-225-reserve-auction-marketplace-main branch April 21, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanev shanev shanev approved these changes

@yubrew yubrew yubrew approved these changes

@jhernandezb jhernandezb jhernandezb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tasiov @shanev @yubrew @jhernandezb