Reserve Auctions (Final) #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o sg-marketplace-common
shanev
reviewed
Jun 30, 2023
shanev
reviewed
Jun 30, 2023
shanev
reviewed
Jun 30, 2023
shanev
reviewed
Jun 30, 2023
shanev
reviewed
Jun 30, 2023
shanev
reviewed
Jun 30, 2023
shanev
reviewed
Jun 30, 2023
shanev
reviewed
Jun 30, 2023
shanev
reviewed
Jun 30, 2023
shanev
reviewed
Jun 30, 2023
| @@ -79,113 +85,132 @@ pub fn execute_create_auction( | |||
| env: Env, | |||
| collection: Addr, | |||
There was a problem hiding this comment.
Since we have to pass around collection and token_id around together in many places, maybe we should have a struct called Nft that includes both in the common code package. Could possibly remove the too_many_arguments with it.
There was a problem hiding this comment.
Hmm yea you are right, let me see...
There was a problem hiding this comment.
It looks like I would have to change the code in a lot of places, almost every message. Maybe it's ok as is?
There was a problem hiding this comment.
@tasiov Okay either way, but grouping related args can make code more readable and an Nft type is something that can be re-used in Marketplace and elsewhere.
shanev
reviewed
Jun 30, 2023
shanev
reviewed
Jun 30, 2023
tasiov
force-pushed
the
reserve-auctions-final
branch
from
55d7321 to
dadb870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.