Remove spm #790
Closed
Remove spm #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am going to separate the SDK upgrade |
|
Here's an example of a similar changeset, also in advance of a 47 upgrade |
Closed
|
Is it possible that this broke the test suite? |
Merged
jhernandezb
reviewed
May 13, 2023
| @@ -151,7 +151,7 @@ DOCKER_BUF := $(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace $( | |||
| ############################################################################### | |||
| ### Protobuf ### | |||
| ############################################################################### | |||
| PROTO_BUILDER_IMAGE=tendermintdev/sdk-proto-gen:v0.2 | |||
| PROTO_BUILDER_IMAGE=ghcr.io/cosmos/proto-builder:0.9.0 | |||
There was a problem hiding this comment.
Question is there is a list of compatible container for proto-builder? I still struggle to find how this container is built!
There was a problem hiding this comment.
here you go:
github.com/faddat/proto-builder
|
Taking a look at this now thanks for getting this started, spm has been annoying since day 1. |
|
@jhernandezb / @spoo-bar -- I'm going to ask some of our team members if they can restructure the disabled tests. It is legitimately a lot of them. |
|
thank you @faddat will start looking on this for our v11 upgrade |
|
Closing spm was removed by a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove cosmoscmd/spm from Stargaze as it is known to cause issues with the cli and there have been
reported cases of it causing instability.
@jhernandezb so, I think the right idea here is to have a look at this PR, note that there were some tests removed, and then we can discuss how to replace them. This PR removes the testutil folder, and can be considered the basis of a clean upgrade to 47.
This PR contains two other PR's:
Bascially, review and merge those and the changeset here will be reduced for easier review.... but also keep in mind that we should go over changes to tests before merging this. I did simply comment some of them out, and this nukes the whole testutil folder.