Update L.ScaleAction method creation to ES6 syntax

[sashadev-sky]

First Time?

This is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

The problem

We just added support for ES6 in our library, and would like to start transitioning our code to use this syntax.

Let's update the method creation syntax in the src/edit/actions/ScaleAction.js file from ES5 to ES6.

Solution

Where to find the relevant lines of code:

For the 2 functions in src/edit/actions/ScaleAction.js, remove the function keyword and attach the method arguments to the method name instead.

Here is an example of how this will look for a different method. These ones should follow suit:

ES5

radiansToDegrees: function(angle) {
  return (angle * 180) / Math.PI;
},

ES6

radiansToDegrees(angle) {
  return (angle * 180) / Math.PI;
},

Thanks!!

Step by Step

• Claim this issue with a comment here, below, and ask any clarifying questions you need
• Fork the repository and set it up locally following the main repo README instructions https://github.com/publiclab/Leaflet.DistortableImage
• Create a new feature branch with a unique name descriptive to the issue
• Try to fix the issue following the steps above, but even before you're done, you can:
  commit your changes to your branch and start a pull request (see contributing to Public Lab software) but mark it as "in progress" if you have questions or if you haven't finished
• Reference this issue in your pull request body
• Once you submit your pull request, if there's an additional checklist provided for getting it merged, get those boxes checked off. Either way, mention me @sashadev-sky for a review.

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

💬 Get help

If you need any help - here are some options:

• Comment below
• Join our gitter chat at https://gitter.im/publiclab/publiclab

[sashadev-sky]

@gunjanaggarwal210 assigning you here!

[NickHolke]

Hello, has this issue already been assigned?

[sashadev-sky]

@NickHolke yes i can assign you to a different one if you'd like

[kczan]

@sashadev-sky Hi, I would gladly take a task too if that's possible! ;)

[theodumont]

@sashadev-sky Hello, I would love to be assigned to a task too if it is possible ! :)

[NickHolke]

@sashadev-sky thank you, but not at the moment. Feel free to assign it to someone else who commented.

[RobNobile]

@sashadev-sky Hi! I'd like to give this a go or be assigned to something similar when available. Thanks!

[romance939913]

Hi @sashadev-sky - I'd like to be assigned this task or take on something similar too if available. Thanks!

[olunusib]

Hi @sashadev-sky, I'm also very interested in getting assigned a task. Regards.

[sashadev-sky]

hi! There are currently 4 pending and I don't want to have too many at once. Ill open more as they are resolved or if theres no activity for 7 days from the contributor i'll reassign to you

[jscastanos]

Hi @sashadev-sky, if there's available task please assign me one too.

[sashadev-sky]

@kczan I am re-assigning you this task! Let me know if you're not interested anymore so I can give it to someone else please

[sashadev-sky]

@theodumont assigned you to #605 :)

[sashadev-sky]

@RobNobile I assigned you to #628

[sashadev-sky]

@olunusib #629 for you

[sashadev-sky]

@jscastanos #630

[RobNobile]

@sashadev-sky Thanks!

[kczan]

@sashadev-sky will gladly take it!

[sashadev-sky]

I don't see any activity from @kczan and it's been quite a while so this PR is up for grabs again!

[tannerdolby]

Hi there, I'm happy to claim this issue! @sashadev-sky

[hrhan]

Hi @sashadev-sky, I'd be happy to take any available tasks :)

[tannerdolby]

@sashadev-sky Must we be assigned first before forking this repo and beginning to update the issue? I was going to finish this issue up today but wanted to wait for your explicit assignment first. Thanks!

[sashadev-sky]

@tannerdolby if you commented first it will be yours, the assigning is just so that other people understand its taken. Assigning you now! Before doing the PR, please read our contributing guidelines and follow the setup process.