-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update L.ScaleAction method creation to ES6 syntax #692
Conversation
Thanks for opening this pull request! |
@tannerdolby sorry for confusing you earlier about the |
@sashadev-sky no problem at all. Thank you for the update. I will uncommit the Would you prefer me to use |
@tannerdolby Doesn't make a difference to me! |
This reverts commit 633cf90.
I reverted the commit for adding |
Thanks this is perfect! The build is passing for node v 10, but failing for node v 12 for reasons unrelated to the changes here. |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Awesome! 🎉 Thank you for such a great experience @sashadev-sky My twitter handle is @tannerdolby |
Fixes #619
Hey @sashadev-sky this PR is ready for your review. I updated L.ScaleAction method creation to ES6 and added commit for the dist file.
I made sure each checkbox below is checked. My local tests pass after running
npm test
.grunt test
Thank you!