Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update L.ScaleAction method creation to ES6 syntax #692

Merged
merged 3 commits into from
Jul 25, 2020
Merged

Update L.ScaleAction method creation to ES6 syntax #692

merged 3 commits into from
Jul 25, 2020

Conversation

tannerdolby
Copy link
Contributor

Fixes #619

Hey @sashadev-sky this PR is ready for your review. I updated L.ScaleAction method creation to ES6 and added commit for the dist file.

I made sure each checkbox below is checked. My local tests pass after running npm test.

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

Thank you!

@welcome
Copy link

welcome bot commented Jul 20, 2020

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@sashadev-sky
Copy link
Member

@tannerdolby sorry for confusing you earlier about the dist file. It will not have any changes to it in this case because we are just updating the syntax of our code, which gets transpiled by babel anyway. So please uncommit the dist file and then ping me here for review again! Thank you :)

@sashadev-sky sashadev-sky self-requested a review July 25, 2020 12:49
@tannerdolby
Copy link
Contributor Author

tannerdolby commented Jul 25, 2020

@sashadev-sky no problem at all. Thank you for the update. I will uncommit the dist file here shortly and ping you for review! :)

Would you prefer me to use git revert <commit> or git rm --cached <file_name>?

@sashadev-sky
Copy link
Member

@tannerdolby Doesn't make a difference to me!

This reverts commit 633cf90.
@tannerdolby
Copy link
Contributor Author

I reverted the commit for adding dist file. Let me know if I made any errors or need to edit anything else to get this merged!

@sashadev-sky
Copy link
Member

Thanks this is perfect! The build is passing for node v 10, but failing for node v 12 for reasons unrelated to the changes here.

@sashadev-sky sashadev-sky merged commit 6960626 into publiclab:main Jul 25, 2020
@welcome
Copy link

welcome bot commented Jul 25, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@tannerdolby tannerdolby deleted the pr/ScaleAction branch July 25, 2020 19:37
@tannerdolby
Copy link
Contributor Author

Awesome! 🎉 Thank you for such a great experience @sashadev-sky

My twitter handle is @tannerdolby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update L.ScaleAction method creation to ES6 syntax
2 participants