Update L.DistortableImage.Edit.js method creation to ES6 syntax III

[sashadev-sky]

First Time?

This is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

The problem

We just added support for ES6 in our library, and would like to start transitioning our code to use this syntax.

Let's update the method creation syntax from ES5 to ES6 for several methods in src/edit/DistortableImage.Edit.js.

Solution

For the following 6 L.DistortableImage.Edit methods, remove the function keyword and attach the method arguments to the method name instead:

• _nextOrNone
• _removeToolbar
• _enableDragging
• _disableDragging
• _dragMode
• _scaleMode

Here is an example of how this will look for a different method. These ones should follow suit:

ES5

radiansToDegrees: function(angle) {
  return (angle * 180) / Math.PI;
},

ES6

radiansToDegrees(angle) {
  return (angle * 180) / Math.PI;
},

Thanks!!

Step by Step

• Claim this issue with a comment here, below, and ask any clarifying questions you need
• Fork the repository and set it up locally following the main repo README instructions https://github.com/publiclab/Leaflet.DistortableImage
• Create a new feature branch with a unique name descriptive to the issue
• Try to fix the issue following the steps above, but even before you're done, you can:
  commit your changes to your branch and start a pull request (see contributing to Public Lab software) but mark it as "in progress" if you have questions or if you haven't finished
• Reference this issue in your pull request body
• Once you submit your pull request, if there's an additional checklist provided for getting it merged, get those boxes checked off. Either way, mention me @sashadev-sky for a review.

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

💬 Get help

If you need any help - here are some options:

• Comment below
• Join our gitter chat at https://gitter.im/publiclab/publiclab

[sashadev-sky]

assigning to @SMAKSS

[SMAKSS]

@sashadev-sky Thank you for assigning this one to me. I just have done it and submitted a PR, but I'm not totally sure if anything alright, because couldn't build it locally but the automatic Travis build ran successfully. If there is any trouble with it please let me know. Thank you again.