Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating L.DistortableImage.Edit.js method creation to ES6 syntax III #731

Conversation

SMAKSS
Copy link
Member

@SMAKSS SMAKSS commented Aug 30, 2020

Fixes #720

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Aug 30, 2020

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SMAKSS this is good to go!! I am going to merge, but let me know if you want any help figuring out how to build the project locally :)

@sashadev-sky sashadev-sky merged commit abb4853 into publiclab:main Sep 1, 2020
@welcome
Copy link

welcome bot commented Sep 1, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@SMAKSS
Copy link
Member Author

SMAKSS commented Sep 1, 2020

@sashadev-sky Thank you a lot. I would love to learn more about it, also I want to contribute more to this repo, so if any other issue is around without an assignee I like to claim it. 😁

@SMAKSS SMAKSS deleted the Update-L.DistortableImage.Edit.js-method-creation-to-ES6-syntax-III branch September 1, 2020 03:45
@sashadev-sky
Copy link
Member

@SMAKSS thats awesome would love to help you get started. Have you tried following the instructions in https://github.com/publiclab/Leaflet.DistortableImage/blob/main/CONTRIBUTING.md

@SMAKSS
Copy link
Member Author

SMAKSS commented Sep 2, 2020

@sashadev-sky It's very odd, I couldn't get npm run setup to work before, but now it's working perfectly. Thank you so much. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update L.DistortableImage.Edit.js method creation to ES6 syntax III
2 participants