-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save map coordinates in local storage #1225
Open
vanithaak
wants to merge
26
commits into
publiclab:main
Choose a base branch
from
vanithaak:localStorage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
87f5076
detect key from longer URL
vanithaak f6225c3
Merge branch 'main' of https://github.com/vanithaak/Leaflet.Distortab…
vanithaak 4976617
Merge branch 'publiclab:main' into main
vanithaak c71fc06
Merge branch 'publiclab:main' into main
vanithaak 8db3a8e
Merge branch 'publiclab:main' into main
vanithaak 1dca9e3
Merge branch 'publiclab:main' into main
vanithaak 7cbcb80
fixes
vanithaak 24df784
Merge branch 'main' of https://github.com/vanithaak/Leaflet.Distortab…
vanithaak 47f1aa2
Merge branch 'publiclab:main' into main
vanithaak 07c7e94
Merge branch 'publiclab:main' into main
vanithaak 773c2fe
Merge branch 'publiclab:main' into main
vanithaak 13c6402
Merge branch 'publiclab:main' into main
vanithaak 67b2862
updates
vanithaak 8407d0f
save map coordinates in local storage
vanithaak 4a1339a
error fixes
vanithaak a03c45c
made a new method to save map in localStorage
vanithaak e409e69
error fixes
vanithaak 415f0da
error fixes X2
vanithaak 44d3a4b
error fixes X3
vanithaak f9e8212
Merge branch 'main' into localStorage
vanithaak eb09b9e
Merge branch 'main' into localStorage
vanithaak 57613e6
removed overwriting of coordinates
vanithaak 5f3e111
removed overwriting of coordinates
vanithaak a798be5
error fixes
vanithaak 96dc9f1
Merge branch 'main' into localStorage
jywarren 7cfe4be
Merge branch 'main' into localStorage
vanithaak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this is looking like a good start, thank you! I wanted to suggest that you build on #1237, because it is almost the same! We'll want to make a function which runs each time there is an update to an image... it could even be each time there's a MouseUp, maybe? And it'll write a new "saved state" into localStorage, and similarly to #1237, not just the selected ones but all the images.
Shall we wait a little bit until #1237 is resolve then? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually wait, cancel that. My mistake. I meant #1161 -- where we are working with the
generateExportJson()
function. Unfortunately I think there is some overlap between #1237 and #1161, and I'd like to ask you and @leilayesufu to try to work together on #1237 and to record a joint contribution. Would you both be willing to try that, since it's quite a complex one? If so, you can mark the PR as collaborative and work on it together.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jeff, I'm little bit confused how to get started on this. Could you please drop some hints? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jeff, just a little hint, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vanithaak -- so, I had realized that I was also working with @leilayesufu on a parallel track on parts of this, in #1161 -- and we had found that the problem was it only downloaded images that have been selected, so we needed to modify
generateExportJson()
to have a anonlySelected
parameter defaulting to true, but so that we can override it if we want ALL images:#1161 (comment)
Once this modification is made, we can use
generateExportJson()
for both downloading a JSON file, and storing the JSON file in localStorage. If you or @leilayesufu are interested in continuing to work on this, I think that's the key. It could even be done as its own PR -- and then we can begin usinggenerateExportJson(false)
to collect ALL images, for saving in localStorage OR for download. Does that make sense?