-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #1332 Updated Document Tooltip Feature in README.md #1336
Conversation
updated readme. md
Thanks for opening this pull request! |
Hello @sudeep162002 Great job 🎉 Kindly add the number to the corresponding issue you solved to help the maintainers. Thank you! I'm sure it'll get reviewed soon @cesswairimu @TildaDares |
Hi @7malikk, feel feee to approve if you think everything looks good. You can either @cesswairimu or me to get it merged. Thank you both! |
Alright, @TildaDares Thank you! |
README.md
Outdated
@@ -77,7 +77,7 @@ map.whenReady(function() { | |||
* [rotation](#rotation) | |||
* [selected](#selected) | |||
* [suppressToolbar](#Suppress-Toolbar) | |||
|
|||
* [tooltipText](#Tooltip-Text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @sudeep162002 Could you remove one space before the text
like so * [tooltipText](#Tooltip-Text)
not * [tooltipText](#Tooltip-Text)
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @sudeep162002
@TildaDares, @cesswairimu I believe this is ready for a merge, thank you! Great job @sudeep162002 🎉 |
@sudeep162002, great effort so far. One little change, please place the second code snippet in line 337 instead (and not 339). Issue #1332 is now updated to reflect this change, sorry for the mix-up. |
Thank you for catching that @segun-codes, must've been an oversight on my part. |
changed the pr according to updated issue please review. |
@sudeep162002, please, fix @7malikk's suggestion above (i.e., replace 0000 in Fixes #0000 (<=== Add issue number here) with the issue number of the issue this PR is related to). |
done . |
@7malikk, things look all set here, over back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @sudeep162002.
Thank you for the reviews @7malikk @segun-codes!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Fixes #1332
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt test
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!