Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move startExport to DistortableCollection.Edit #384

Merged
merged 2 commits into from
Aug 16, 2019

Conversation

sashadev-sky
Copy link
Member

Fixes #381 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@sashadev-sky
Copy link
Member Author

@jywarren In #381 I should have moved startExport to DistortableCollection.Edit with the rest of the actions connected to the toolbar. Created a bug "startExport is not a function". This fixes that. bumping to 0.7.2 and merging because 0.7.1 has that bug

@sashadev-sky
Copy link
Member Author

looping in @rexagod

@sashadev-sky sashadev-sky merged commit 9b63f8b into publiclab:main Aug 16, 2019
sashadev-sky added a commit that referenced this pull request Sep 15, 2019
* move startexport TO DistortableCollection.Edit

* bump to 0.7.2
themacboy pushed a commit to themacboy/Leaflet.DistortableImage that referenced this pull request Sep 19, 2019
* move startexport TO DistortableCollection.Edit

* bump to 0.7.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant