Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dependancy types in package.json #411 #428

Merged
merged 2 commits into from
Sep 14, 2019

Conversation

GianCastle
Copy link
Contributor

  • Relocation of jQuery from devDepencies to depencies

Fixes #411
@rexagod @sashadev-sky

Cheers!

- Relocation of jQuery from devDepencies to depencies
@welcome
Copy link

welcome bot commented Sep 8, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GianCastle thank you so much this is great! Sorry for the late review. all you need to do to fix it up is run $npm install locally on your machine so that package-lock.json updates. and push that file up as well.

Thank you for the contribution!

Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GianCastle looks great thank you! This one is ready for merge :)

@sashadev-sky sashadev-sky merged commit 075e335 into publiclab:main Sep 14, 2019
@welcome
Copy link

welcome bot commented Sep 14, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@GianCastle GianCastle deleted the patch-1 branch September 14, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor dependancy types in package.json
2 participants