Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove try...catch from _addToolbar in src/edit/DistortableImage.Edit.js #490

Merged

Conversation

alexbertis
Copy link
Contributor

Fixes #383

Part of the "Remove try...catch from _addToolbar" task from Google Code-in (alias: alexberti02).

@welcome
Copy link

welcome bot commented Dec 23, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Just one thing please can you delete the extra blank line? I added a commit suggestion for this. Thank you!!!

}).addTo(map, ov);
ov.fire('toolbar:created');
} catch (e) { }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@sashadev-sky sashadev-sky merged commit 16de542 into publiclab:main Jan 8, 2020
@welcome
Copy link

welcome bot commented Jan 8, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove try...catch from _addToolbar
2 participants