-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 582 - L.DragHanlde class initializer #624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great thank you!! One more thing - you need to also commit the dist file. Please run npm run build
and you should see it updated
Hey @sashadev-sky, I tried to run npm run build but I am getting the following error. Can you please look into this? `
Running "jshint:source" (jshint) task
Running "jshint:grunt" (jshint) task
Running "karma:development:start" (karma) task START: Finished in 0.292 secs / 0 secs @ 00:42:25 GMT+0500 (Pakistan Standard Time) SUMMARY: Aborted due to warnings. npm ERR! A complete log of this run can be found in: |
@iAmmar7 try
|
@sashadev-sky It seems to have some conflicts now. |
@iAmmar7 no problem i'll fix it for you and merge. We should be updating that part of our development process soon. Thank you! |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Fixes #582 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt test
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!