Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 582 - L.DragHanlde class initializer #624

Merged
merged 3 commits into from
Apr 21, 2020

Conversation

iAmmar7
Copy link
Contributor

@iAmmar7 iAmmar7 commented Apr 17, 2020

Fixes #582 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thank you!! One more thing - you need to also commit the dist file. Please run npm run build and you should see it updated

@iAmmar7
Copy link
Contributor Author

iAmmar7 commented Apr 17, 2020

Hey @sashadev-sky, I tried to run npm run build but I am getting the following error. Can you please look into this?

`
$ npm run build

leaflet-distortableimage@0.16.6 build D:\VSCode\OpenSource-Contributions\Leaflet.DistortableImage
cross-env NODE_ENV=production grunt build

Local Npm module "grunt-cli" not found. Is it installed?

Running "jshint:source" (jshint) task

44 files lint free.

Running "jshint:grunt" (jshint) task

1 file lint free.

Running "karma:development:start" (karma) task

START:
18 04 2020 00:42:14.500:WARN [filelist]: Pattern "D:/VSCode/OpenSource-Contributions/Leaflet.DistortableImage/node_modules/leaflet/dist/leaflet-src.js" does not match any file.
18 04 2020 00:42:14.536:WARN [filelist]: Pattern "D:/VSCode/OpenSource-Contributions/Leaflet.DistortableImage/node_modules/leaflet/dist/leaflet.css" does not match any file.
18 04 2020 00:42:14.537:WARN [filelist]: All files matched by "D:/VSCode/OpenSource-Contributions/Leaflet.DistortableImage/node_modules/sinon/pkg/sinon.js" were excluded or matched by prior matchers.
18 04 2020 00:42:20.996:INFO [karma-server]: Karma v5.0.1 server started at http://0.0.0.0:9876/
18 04 2020 00:42:20.997:INFO [launcher]: Launching browsers PhantomJS with concurrency unlimited
18 04 2020 00:42:21.005:INFO [launcher]: Starting browser PhantomJS
18 04 2020 00:42:25.249:INFO [PhantomJS 2.1.1 (Windows 8)]: Connected on socket QrtxbgXcvzx37MbpAAAA with id 40740145
PhantomJS 2.1.1 (Windows 8) ERROR
ReferenceError: Can't find variable: L
at node_modules/leaflet-toolbar/dist/leaflet.toolbar.js:1:46

Finished in 0.292 secs / 0 secs @ 00:42:25 GMT+0500 (Pakistan Standard Time)

SUMMARY:
√ 0 tests completed
Warning: Task "karma:development:start" failed. Use --force to continue.

Aborted due to warnings.
npm ERR! code ELIFECYCLE
npm ERR! errno 3
npm ERR! leaflet-distortableimage@0.16.6 build: cross-env NODE_ENV=production grunt build
npm ERR! Exit status 3
npm ERR!
npm ERR! Failed at the leaflet-distortableimage@0.16.6 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\m-a-a\AppData\Roaming\npm-cache_logs\2020-04-17T19_42_25_756Z-debug.log
`

@sashadev-sky
Copy link
Member

@iAmmar7 try

npm install
npm install leaflet --no-save
npm run build

@iAmmar7
Copy link
Contributor Author

iAmmar7 commented Apr 21, 2020

@sashadev-sky It seems to have some conflicts now.

@sashadev-sky
Copy link
Member

sashadev-sky commented Apr 21, 2020

@iAmmar7 no problem i'll fix it for you and merge. We should be updating that part of our development process soon. Thank you!

@sashadev-sky sashadev-sky self-requested a review April 21, 2020 18:59
@sashadev-sky sashadev-sky merged commit 62da2c0 into publiclab:main Apr 21, 2020
@welcome
Copy link

welcome bot commented Apr 21, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update L.DragHandle initializer to class factory syntax
2 participants