Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis config #695

Merged
merged 3 commits into from
Jul 25, 2020
Merged

Conversation

sashadev-sky
Copy link
Member

@sashadev-sky sashadev-sky commented Jul 25, 2020

Fixes #625 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Jul 25, 2020

@sashadev-sky
Copy link
Member Author

@jywarren @VladimirMikulic a few optimizations here... npm run build already runs our tests so we don't need to run grunt test as well (we were running specs twice before).

Also, I set browserDisconnectTolerance: 5. This means it will retry 5 times if it disconnects. This should prevent the builds from failing.

Will look into further optimizations suggested by @jywarren in other PRs

@sashadev-sky sashadev-sky merged commit 00407e0 into publiclab:main Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis build taking up to 3 rebuilds to pass
2 participants