Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toolbar icons in multi-image view are not selectable #699

Merged
merged 6 commits into from
Aug 18, 2020

Conversation

sashadev-sky
Copy link
Member

@sashadev-sky sashadev-sky commented Jul 25, 2020

Fixes #698 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

========
Bug fixes:

  • Fix bug where toolbar icons in multi-image view are not selectable
  • Stop allowing deletion, lock, unlock, & export of collection of images by hotkey when the corresponding collection tool isn't present
  • Fix mixup with structure of question when confirming deletion of multiple images
  • Fix bug where you cant do multi image delete if the single image doesnt have a delete tool
  • Bump version to 0.20.7
    =========

@gitpod-io
Copy link

gitpod-io bot commented Jul 25, 2020

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job as always!

@sashadev-sky sashadev-sky force-pushed the fix-collection-actions branch from 9e7ed6f to 516415f Compare August 18, 2020 01:18
@sashadev-sky sashadev-sky merged commit 2cb509e into publiclab:main Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toolbar icons in multi-image view are not selectable besides lock, transparency, delete
2 participants