Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misaligned placeholder text in https://publiclab.org/post #623

Closed
daemon1024 opened this issue Sep 28, 2020 · 9 comments
Closed

Misaligned placeholder text in https://publiclab.org/post #623

daemon1024 opened this issue Sep 28, 2020 · 9 comments
Labels

Comments

@daemon1024
Copy link
Member

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

image

What did you expect to see that you didn't?

the placeholder text should be insides the box

Please show us where to look

https://publiclab.org/post

What's your PublicLab.org username?

barun1024

This can help us diagnose the issue:

Browser, version, and operating system

Chrome , Firefox , Windows , NixOS

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@daemon1024 daemon1024 added the bug label Sep 28, 2020
@welcome
Copy link

welcome bot commented Sep 28, 2020

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

@daemon1024
Copy link
Member Author

This can be reproduced if

<textarea class="ple-textarea form-control">

placeholder attribute is added to the above tag in example/index.html

@dharmelolar
Copy link

Hello @daemon1024 can i work on this fix? I just checked now and the issue has not been solved
Screenshot (3)_LI

@daemon1024
Copy link
Member Author

daemon1024 commented Oct 15, 2020

@dharmelolar Sure.

cc @publiclab/editor @Sagarpreet

@dharmelolar
Copy link

Hello @daemon1024 after fixing the bug in this issue, I realized there'still something that needs to be done, even after fixing the bug, this text still shows in the textarea.
Screenshot (5)

@dharmelolar
Copy link

But after deleting this text in my editor, the code work perfectly.
Screenshot (6)
Screenshot (4)

@dharmelolar
Copy link

Please kindly advice

@Sagarpreet
Copy link
Contributor

Hey @dharmelolar , thanks for investigating but this is solved in #635
You can try the gitpod link in that PR to verify this: https://a15099a1-0d3a-4e36-bd91-aa4ce8a78b5c.ws-us02.gitpod.io/#/workspace/PublicLab.Editor
Thanks for the help 😄 Looking forward to have you contribute in any other issue 🎉

@ebarry
Copy link
Member

ebarry commented Oct 16, 2020

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants