Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poorly wrapping Markdown button on narrower screens on /post #635

Merged
merged 4 commits into from
Oct 13, 2020
Merged

poorly wrapping Markdown button on narrower screens on /post #635

merged 4 commits into from
Oct 13, 2020

Conversation

Sagarpreet
Copy link
Contributor

Before:

Screenshot 2020-10-13 at 1 34 24 PM

Screenshot 2020-10-13 at 1 33 32 PM

After:
Screenshot 2020-10-13 at 1 30 53 PM

Screenshot 2020-10-13 at 12 58 53 PM

@gitpod-io
Copy link

gitpod-io bot commented Oct 13, 2020 •
edited
Loading

@Sagarpreet
Copy link
Contributor Author

Fixes 2 things:

  1. "Enter the content here" placeholder was out of box.
  2. Editor Buttons on smaller screen were not wrapping properly

@Sagarpreet Sagarpreet mentioned this pull request Oct 13, 2020
Closed
14 tasks
@Sagarpreet
Copy link
Contributor Author

@jywarren kindly review this

@jywarren jywarren closed this Oct 13, 2020
@jywarren jywarren reopened this Oct 13, 2020
@gitpod-io
Copy link

gitpod-io bot commented Oct 13, 2020

@jywarren
Copy link
Member

Trying to get GitPod to run successfully, it had stalled!

@jywarren
Copy link
Member

Ah, i think this now needs a conflict resolved. Thanks @Sagarpreet !!!

@Sagarpreet
Copy link
Contributor Author

Done @jywarren 👍

@jywarren jywarren merged commit 63526e0 into publiclab:main Oct 13, 2020
@jywarren
Copy link
Member

Awesome! Thanks!!!

@Sagarpreet Sagarpreet mentioned this pull request Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sagarpreet @jywarren