-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the site responsive #1381
Comments
Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄 |
@VladimirMikulic thanks for opening up the issue.this issue was fixed.please clear the cache.you will then be able to see the changes.although you will still face issue of text squashing.so please change the issue accordingly. |
@keshav234156 I've cleared cache and yes the issue is gone(no squished text). |
@VladimirMikulic are you reffering to scrolling as overflowing.if yes, then i thinks it is needed so that think don't get squashed.is there any better way? |
@keshav234156 good news! I've updated the issue accordingly, it will make the website responsive and look great on mobile devices 🚀 |
I am totally new to open source. Is this a task that when someone complete it, it is closed? Or everybody can do this as an exercise? Angelo |
Hi @AngeloSorte and welcome to PublicLab 🎈 It's all yours, go for it 🚀 |
I made the changes for issue #1381 and created a pull request for the changes I made. Not sure if I did it completely right so I wouldn't mind some feedback on whether I did it correct or not. |
Hi @adamg703. I've left a comment on your PR :) |
Hi I’m new here :) excited to have found you guys. Is it ok to work on this still? |
Hi @KateAnn19, it's nice to have you here at PublicLab 🚀 You can check out other first-timers-issues :) |
Hi, can i work on this ? |
Hi @28-ys. We already have a PR that resolves this issue. Could you please check other issues? |
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
🔥 Problem
The current version of the site is not responsive. 😢
Your job is to make it look great on mobile devices. 📱
Don't worry though, it will only take you a few simple edits. 📝
🚩 Goal
📋 Step by Step
🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Open image-sequencer/examples/demo.css
Below
#gif
selector(line 154) add this code:line
47
-> removemin-width
ruleline
69
-> removemin-width
ruleOpen image-sequencer/examples/index.html
58
remove inline styles from headerSee this page for some help in taking your first steps!
Below is a "diff" showing in red (and a
-
) which lines to remove, and in green (and a+
) which lines to add:💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.
Please keep us updated
💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!
If this happens to you, don't sweat it! Grab another open issue.
Is someone else already working on this?
🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.
👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
🤔❓ Questions?
Leave a comment below!
The text was updated successfully, but these errors were encountered: