Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving buttons for smaller screens #582

Closed
vibhorgupta-gh opened this issue Dec 31, 2018 · 8 comments
Closed

Improving buttons for smaller screens #582

vibhorgupta-gh opened this issue Dec 31, 2018 · 8 comments
Labels

Comments

@vibhorgupta-gh
Copy link

vibhorgupta-gh commented Dec 31, 2018

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

The buttons save sequence and view gif are too wide and have no margin at all in mobile and tablet views. They even flow out of the div, and hence out of the device screen. This is undesirable, buttons should change their shape according to the device.

screen shot 2018-12-31 at 10 33 56 pm

screen shot 2018-12-31 at 10 34 28 pm

What did you expect to see that you didn't?

Well-aligned and spaced buttons

Please show us where to look

http://sequencer.publiclab.org

This can help us diagnose the issue:

Observe the mobile/tablet view

Browser, version, and operating system

Chrome/Safari; OSX 10.13


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@welcome
Copy link

welcome bot commented Dec 31, 2018

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

@gitmate gitmate bot added the small label Dec 31, 2018
@gitmate
Copy link

gitmate bot commented Dec 31, 2018

GitMate.io thinks the contributors most likely able to help are @oorjitchowdhary, and @GitMate[bot].

Possibly related issues are #373 (Button to top), #348 (Improve Images step Ui), #346 (Include a back-to-top Button on scrolling down), #471 (Change Gif to GIF in 'View Gif' button.), and #569 (add toggle-able collapse button for modules ).

1 similar comment
@gitmate
Copy link

gitmate bot commented Dec 31, 2018

GitMate.io thinks the contributors most likely able to help are @oorjitchowdhary, and @GitMate[bot].

Possibly related issues are #373 (Button to top), #348 (Improve Images step Ui), #346 (Include a back-to-top Button on scrolling down), #471 (Change Gif to GIF in 'View Gif' button.), and #569 (add toggle-able collapse button for modules ).

@jywarren
Copy link
Member

jywarren commented Jan 2, 2019 via email

@vibhorgupta-gh
Copy link
Author

vibhorgupta-gh commented Jan 3, 2019

@jywarren yes, this can be achieved using btn-block as well, but the white panel behind the two buttons doesn't adjust it's size, and additional css might be required there (which I haven't figured out yet). Example:

screen shot 2019-01-03 at 11 22 20 am

How would you suggest we proceed? Using btn-block gets the desired result without changing the size of the background panel though.

@vibhorgupta-gh
Copy link
Author

@jywarren #583 however, takes care of the white panel background as well, which looks prettier IMO. Thoughts?

@jywarren
Copy link
Member

jywarren commented Jan 4, 2019

OK, would you like to close this and solve over there? Thanks!

@vibhorgupta-gh
Copy link
Author

@jywarren sure, I'll close this and update the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants