Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resize before loading previews #1180

Merged
merged 2 commits into from
Jul 22, 2019
Merged

resize before loading previews #1180

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf25672
resize before loading previews
aashna27 Jul 20, 2019
bce8f3f
min resize percentage calculated
aashna27 Jul 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions examples/lib/insertPreview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ function generatePreview(previewStepName, customValues, path, selector) {
previewSequencer.addSteps(previewStepName, { [previewStepName]: customValues }).run(insertPreview);
}
}
previewSequencer.loadImage(path, loadPreview);
if(previewStepName === 'resize')
insertPreview(path);
else
previewSequencer.loadImage(path, loadPreview);
}

function updatePreviews(src, selector) {
Expand All @@ -44,9 +47,17 @@ function updatePreviews(src, selector) {
}
};

Object.keys(previewSequencerSteps).forEach(function (step, index) {
generatePreview(step, Object.values(previewSequencerSteps)[index], src, selector);
var sequencer = ImageSequencer();

sequencer.loadImage(src, function(){
this.addSteps('resize', {['resize']: '30%'});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we limit to a fixed size? Like 100x100? Because really large images at 30% are still quite large!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but idt we have that option in resize.

this.run((src)=>{
Object.keys(previewSequencerSteps).forEach(function (step, index) {
generatePreview(step, Object.values(previewSequencerSteps)[index], src, selector);
});
});
});

}

module.exports = {
Expand Down