-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Missing Modules to Documentation #1325
Conversation
Thanks for opening this pull request! |
@publiclab/is-reviewers Please review this. Thank you! |
Codecov Report
@@ Coverage Diff @@
## main #1325 +/- ##
=======================================
Coverage 66.57% 66.57%
=======================================
Files 125 125
Lines 2546 2546
Branches 397 397
=======================================
Hits 1695 1695
Misses 851 851 |
Welcome to Public Labs @Ryan10145! If you haven't already, be sure to check out the welcoming post at publiclab/plots2#6808. |
Looks great @Ryan10145 thanks for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@jywarren can you please review and merge the changes asap |
Just checking, Harsh are you participating in GCI ? |
Yup. This review was a part of the gci task.
…On Fri, 6 Dec, 2019, 10:55 PM Sidharth Bansal, ***@***.***> wrote:
Just checking, Harsh are you participating in GCI ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1325?email_source=notifications&email_token=AIJI5HYAV3Y5UACHHHB5Y53QXKDG7A5CNFSM4JVT4G72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGEZAJQ#issuecomment-562663462>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJI5H3VHO3JDIE6OZIO2YTQXKDG7ANCNFSM4JVT4G7Q>
.
|
Yeah! Great to see you at GCI 2020
On Fri, Dec 6, 2019 at 10:58 PM Harsh Khandeparkar <notifications@github.com>
wrote:
… Yup. This review was a part of the gci task.
On Fri, 6 Dec, 2019, 10:55 PM Sidharth Bansal, ***@***.***>
wrote:
> Just checking, Harsh are you participating in GCI ?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#1325?email_source=notifications&email_token=AIJI5HYAV3Y5UACHHHB5Y53QXKDG7A5CNFSM4JVT4G72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGEZAJQ#issuecomment-562663462
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AIJI5H3VHO3JDIE6OZIO2YTQXKDG7ANCNFSM4JVT4G7Q
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1325?email_source=notifications&email_token=AFAAEQYHGCJWV77SXXSQ5I3QXKDVDA5CNFSM4JVT4G72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGEZLUA#issuecomment-562664912>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAAEQ5IKSUOUVDMWA7FCVTQXKDVDANCNFSM4JVT4G7Q>
.
|
This is also good to merge now. Thanks! |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Fixes #1291 (<=== Replace
0000
with the Issue Number)Adds the following modules to the documentation:
These modules are in the current stable build but are not currently in the documentation.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!