Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Add Step" button blue #1331

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Make "Add Step" button blue #1331

merged 2 commits into from
Dec 9, 2019

Conversation

anthony-zhou
Copy link
Member

@anthony-zhou anthony-zhou commented Dec 6, 2019

I changed the "Add Step" button's class from "btn-success" to "btn-primary," to make it blue. This means the "btn-success" CSS rule might no longer be used, but I haven't changed any CSS, in case the "btn-success" class is used elsewhere.
Here is a screenshot:
image

Note: I also claimed this task on Google Code-in. My Google Code-in username is az.

Fixes #1317

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

Changed the button's class from "btn-success" to "btn-primary."
@welcome
Copy link

welcome bot commented Dec 6, 2019

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #1331 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1331   +/-   ##
=======================================
  Coverage   32.13%   32.13%           
=======================================
  Files         108      108           
  Lines        1982     1982           
  Branches      292      292           
=======================================
  Hits          637      637           
  Misses       1345     1345

@chen-robert
Copy link

Great PR @anthony-zhou, it works for me 😄

Be sure to check out the welcoming post at #6808. You should also make sure that you've completed the installation task for image-sequencer before working on any issues.

Glad to have you here 🎉

@SidharthBansal
Copy link
Member

@keshav234156 @jywarren kindly review this.
I am not having any specialism in this repo.

@SidharthBansal
Copy link
Member

Glad to have your help @anthony-zhou 🎉

@keshav234156
Copy link
Member

keshav234156 commented Dec 6, 2019

@anthony-zhou Changes looks great to me! Can you please also add a screenshot of the button after changes are made.

@anthony-zhou
Copy link
Member Author

@keshav234156 Thanks for the feedback. I have added a screenshot of the button after the changes were made. Let me know if you need anything else!

@keshav234156
Copy link
Member

@anthony-zhou Oh great!Nicely done
@jywarren what are your views on this

@anthony-zhou
Copy link
Member Author

@chen-robert Thanks! I successfully installed image-sequencer, so I'll be sure to go complete the installation task as soon as I have completed this one. (Sorry for going out of order; I didn't notice the the welcome post before opening this PR.)

@anthony-zhou
Copy link
Member Author

@publiclab/is-reviewers Would anyone else like to review this PR?

@SidharthBansal
Copy link
Member

SidharthBansal commented Dec 8, 2019 via email

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Dec 8, 2019 via email

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@harshkhandeparkar
Copy link
Member

Well done!

@harshkhandeparkar
Copy link
Member

@jywarren this can be merged.

@jywarren jywarren merged commit 510fd7a into publiclab:main Dec 9, 2019
@welcome
Copy link

welcome bot commented Dec 9, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

jywarren commented Dec 9, 2019

Thanks all!

jywarren pushed a commit that referenced this pull request Dec 16, 2019
Changed the button's class from "btn-success" to "btn-primary."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Add step button blue in color.
6 participants