-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "Add Step" button blue #1331
Conversation
Changed the button's class from "btn-success" to "btn-primary."
Thanks for opening this pull request! |
Codecov Report
@@ Coverage Diff @@
## main #1331 +/- ##
=======================================
Coverage 32.13% 32.13%
=======================================
Files 108 108
Lines 1982 1982
Branches 292 292
=======================================
Hits 637 637
Misses 1345 1345 |
Great PR @anthony-zhou, it works for me 😄 Be sure to check out the welcoming post at #6808. You should also make sure that you've completed the installation task for image-sequencer before working on any issues. Glad to have you here 🎉 |
@keshav234156 @jywarren kindly review this. |
Glad to have your help @anthony-zhou 🎉 |
@anthony-zhou Changes looks great to me! Can you please also add a screenshot of the button after changes are made. |
@keshav234156 Thanks for the feedback. I have added a screenshot of the button after the changes were made. Let me know if you need anything else! |
@anthony-zhou Oh great!Nicely done |
@chen-robert Thanks! I successfully installed image-sequencer, so I'll be sure to go complete the installation task as soon as I have completed this one. (Sorry for going out of order; I didn't notice the the welcome post before opening this PR.) |
@publiclab/is-reviewers Would anyone else like to review this PR? |
@harshkhandeparkar please review.
…On Sun, 8 Dec 2019, 11:33 pm anthony-zhou, ***@***.***> wrote:
@publiclab/is-reviewers
<https://github.com/orgs/publiclab/teams/is-reviewers> Would anyone else
like to review this PR?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1331?email_source=notifications&email_token=AFAAEQ55ZGN6STHYVKYNCDTQXUZHPA5CNFSM4JW44B3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGHFFGA#issuecomment-562975384>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAAEQ3CEL7574AH3F3RC53QXUZHPANCNFSM4JW44B3A>
.
|
Sure.
On Sun, 8 Dec, 2019, 11:48 PM Sidharth Bansal, <notifications@github.com>
wrote:
… @harshkhandeparkar please review.
On Sun, 8 Dec 2019, 11:33 pm anthony-zhou, ***@***.***>
wrote:
> @publiclab/is-reviewers
> <https://github.com/orgs/publiclab/teams/is-reviewers> Would anyone else
> like to review this PR?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#1331?email_source=notifications&email_token=AFAAEQ55ZGN6STHYVKYNCDTQXUZHPA5CNFSM4JW44B3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGHFFGA#issuecomment-562975384
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AFAAEQ3CEL7574AH3F3RC53QXUZHPANCNFSM4JW44B3A
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1331?email_source=notifications&email_token=AIJI5H3NVKZEX5Z5DO5B2WDQXU3APA5CNFSM4JW44B3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGHFSCQ#issuecomment-562977034>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJI5H4ZSJ27WBJMEHDBMQTQXU3APANCNFSM4JW44B3A>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Well done! |
@jywarren this can be merged. |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Thanks all! |
Changed the button's class from "btn-success" to "btn-primary."
I changed the "Add Step" button's class from "btn-success" to "btn-primary," to make it blue. This means the "btn-success" CSS rule might no longer be used, but I haven't changed any CSS, in case the "btn-success" class is used elsewhere.
Here is a screenshot:
Note: I also claimed this task on Google Code-in. My Google Code-in username is az.
Fixes #1317
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!