Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCI] Standardised Blob Analysis module comments #1351

Merged
merged 7 commits into from
Dec 16, 2019
Merged

[GCI] Standardised Blob Analysis module comments #1351

merged 7 commits into from
Dec 16, 2019

Conversation

harshkhandeparkar
Copy link
Member

@harshkhandeparkar harshkhandeparkar commented Dec 10, 2019

Fixes #1350 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@harshkhandeparkar
Copy link
Member Author

@SidharthBansal @jywarren here's the last PR with two more file changes. Please try to merge this soon as the deadline is only 2 days away. Thanks a lot to all!

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #1351 into main will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1351   +/-   ##
=======================================
  Coverage   66.41%   66.41%           
=======================================
  Files         125      125           
  Lines        2552     2552           
  Branches      397      397           
=======================================
  Hits         1695     1695           
  Misses        857      857
Impacted Files Coverage Δ
src/modules/BlobAnalysis/Module.js 28.57% <0%> (ø) ⬆️

@SidharthBansal
Copy link
Member

Tip: start opening ftos to get points.
Documentation from will contain points too.
If you are free you can do that. :-)
Don't write diff. Instead ask them what good documentation needs. And help them to implement good docs.
Don't provide diff. That is no learning from my point of view. Especially in case of documentation
Thanks 😊

@SidharthBansal
Copy link
Member

Please don't create all documentation ftos in a single day. That will cause a flood of documentation and we need to close. So limit it to 1-2 per day.
However you can create as many non documentation ftos as you want per day in any repo.
Also, you can create 1-2 documentation ftos per day in other repos if you are familiar with the code.
Thanks

@harshkhandeparkar
Copy link
Member Author

I know. I am going to open a few docs FTOs once this task is over. TY.

@harshkhandeparkar
Copy link
Member Author

Have you read the sub-issues I opened? Do you think it will be good if I make more such issues but in the FTO format for GCI?

@SidharthBansal
Copy link
Member

SidharthBansal commented Dec 12, 2019 via email

src/modules/BlobAnalysis/BlobAnalysis.js Outdated Show resolved Hide resolved
src/modules/BlobAnalysis/Module.js Outdated Show resolved Hide resolved
@SidharthBansal
Copy link
Member

Kindly remove two .
Let's complete all your prs today. Only . errors are remaining I guess

@harshkhandeparkar
Copy link
Member Author

Okay. Ty.

Copy link
Member

@SidharthBansal SidharthBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jywarren kindly review and merge it
I am just trying to make docs consistent throughout the repo with help of Harsh.
THanks all

Copy link
Member

@SidharthBansal SidharthBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jywarren kindly merge it

@jywarren jywarren merged commit 0ce2cf9 into publiclab:main Dec 16, 2019
@jywarren
Copy link
Member

Fantastic work! Thanks!!

jywarren pushed a commit that referenced this pull request Dec 16, 2019
* fix comments

* Update src/modules/BlobAnalysis/BlobAnalysis.js

Fix double image

* Update src/modules/BlobAnalysis/BlobAnalysis.js

* . fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardise Blob Analysis module comments
3 participants