-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCI] Standardised Blob Analysis module comments #1351
[GCI] Standardised Blob Analysis module comments #1351
Conversation
@SidharthBansal @jywarren here's the last PR with two more file changes. Please try to merge this soon as the deadline is only 2 days away. Thanks a lot to all! |
Codecov Report
@@ Coverage Diff @@
## main #1351 +/- ##
=======================================
Coverage 66.41% 66.41%
=======================================
Files 125 125
Lines 2552 2552
Branches 397 397
=======================================
Hits 1695 1695
Misses 857 857
|
Tip: start opening ftos to get points. |
Please don't create all documentation ftos in a single day. That will cause a flood of documentation and we need to close. So limit it to 1-2 per day. |
Fix double image
I know. I am going to open a few docs FTOs once this task is over. TY. |
Have you read the sub-issues I opened? Do you think it will be good if I make more such issues but in the FTO format for GCI? |
Commented on it.
I asked you to open the other ftos so that you will remain not be blocked
due to lesser availability of mentors. This year gci is epic so it is
taking a lot of time.
…On Wed, 11 Dec 2019, 8:55 pm Harsh Khandeparkar, ***@***.***> wrote:
Have you read the sub-issues I opened? Do you think it will be good if I
make more such issues but in the FTO format for GCI?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1351?email_source=notifications&email_token=AFAAEQYILO6M642K76CP7MTQYEA7PA5CNFSM4JZCBTT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGTQUHY#issuecomment-564595231>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAAEQ7Y5VRMTO7N55B6RSLQYEA7PANCNFSM4JZCBTTQ>
.
|
Kindly remove two . |
Okay. Ty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jywarren kindly review and merge it
I am just trying to make docs consistent throughout the repo with help of Harsh.
THanks all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jywarren kindly merge it
Fantastic work! Thanks!! |
* fix comments * Update src/modules/BlobAnalysis/BlobAnalysis.js Fix double image * Update src/modules/BlobAnalysis/BlobAnalysis.js * . fix
Fixes #1350 (<=== Replace
0000
with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!