-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the button to blue from green #1380
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1380 +/- ##
=======================================
Coverage 66.12% 66.12%
=======================================
Files 125 125
Lines 2571 2571
Branches 404 404
=======================================
Hits 1700 1700
Misses 871 871
|
@ikayz Please add a Screenshot and issue number in PR description |
@keshav234156 of the button? |
@ikayz yes |
@keshav234156 I've added the screenshot and description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but I don't think the screenshot shows the insert-step button but the main selector button.
@harshkhandeparkar I've added the correct screenshot, thanks. Also please refer to this pull request not the one from before in the comments section of this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!
Congrats on merging your first pull request! 🙌🎉⚡️ |
Thank you so much! Apologies for the slow response during holidays!!! |
@jywarren it's alright, thank you for the opportunity of contributing to your code base. My Twitter handle is @ikayz360 |
Twitter handle @ikayz360 |
Fixes #1361 button has been changed from green to blue
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!