Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the button to blue from green #1380

Merged
merged 2 commits into from
Jan 1, 2020
Merged

Change the button to blue from green #1380

merged 2 commits into from
Jan 1, 2020

Conversation

ikayz
Copy link
Member

@ikayz ikayz commented Dec 20, 2019

Fixes #1361 button has been changed from green to blue

button-change

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #1380 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1380   +/-   ##
=======================================
  Coverage   66.12%   66.12%           
=======================================
  Files         125      125           
  Lines        2571     2571           
  Branches      404      404           
=======================================
  Hits         1700     1700           
  Misses        871      871
Impacted Files Coverage Δ
examples/lib/intermediateHtmlStepUi.js 11.11% <ø> (ø) ⬆️

@keshav234156
Copy link
Member

keshav234156 commented Dec 20, 2019

@ikayz Please add a Screenshot and issue number in PR description

@ikayz
Copy link
Member Author

ikayz commented Dec 20, 2019

@keshav234156 of the button?

@keshav234156
Copy link
Member

@ikayz yes

@ikayz
Copy link
Member Author

ikayz commented Dec 20, 2019

@keshav234156 I've added the screenshot and description.

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I don't think the screenshot shows the insert-step button but the main selector button.

@ikayz
Copy link
Member Author

ikayz commented Dec 20, 2019

@harshkhandeparkar I've added the correct screenshot, thanks. Also please refer to this pull request not the one from before in the comments section of this issue.

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

@jywarren jywarren merged commit cb47bf2 into publiclab:main Jan 1, 2020
@welcome
Copy link

welcome bot commented Jan 1, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

jywarren commented Jan 1, 2020

Thank you so much! Apologies for the slow response during holidays!!!

@ikayz
Copy link
Member Author

ikayz commented Jan 1, 2020

@jywarren it's alright, thank you for the opportunity of contributing to your code base. My Twitter handle is @ikayz360

@ikayz
Copy link
Member Author

ikayz commented Jan 1, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

Twitter handle @ikayz360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert Step 'Add Step' button should be blue
4 participants