-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse floating-point value from percentages #1733
Parse floating-point value from percentages #1733
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct. |
Codecov Report
@@ Coverage Diff @@
## main #1733 +/- ##
==========================================
- Coverage 66.67% 65.46% -1.22%
==========================================
Files 130 133 +3
Lines 2686 2748 +62
Branches 433 440 +7
==========================================
+ Hits 1791 1799 +8
- Misses 895 949 +54
|
Would you mind adding a test for this? |
Sure. Will do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests! Thank you!!!
Congrats on merging your first pull request! 🙌🎉⚡️ |
Pinned issue section? I guess this is specific for plots2, isn't it? |
Fixes #1725
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm run test-all
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!