Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for Reviewers πŸŽ‰ #634

Open
grvsachdeva opened this issue May 25, 2019 · 7 comments Β· Fixed by #701
Open

Call for Reviewers πŸŽ‰ #634

grvsachdeva opened this issue May 25, 2019 · 7 comments Β· Fixed by #701

Comments

@grvsachdeva
Copy link
Member

Hi everyone, our community is growing fast πŸš€ ⚑. Thanks to the number of contributions each one of you has made. With the growth of new contributors to the Mapknitter and so many new and exciting projects, we want your help with reviewing and so we invite people to step up and volunteer to be the part of reviewers group πŸ˜ƒ. Also, we are preparing the software community roadmap at https://publiclab.org/notes/warren/05-22-2019/draft-of-a-public-lab-software-roadmap-comments-welcome so comments and suggestions are welcome!!

Community growth

This is especially important as our community around Mapknitter has grown so much in the past few months!

Check out some of these pages to see how many people have helped build mapknitter, since we really started doing welcoming and outreach:

What's next: co-review workflow

To build on this community strength 🀝, we'd like to ask for people to sign up as reviewers, to help get pull requests ready for merging. In the new workflow, we'd like each PR to have:

  • βœ… 2 reviews by people from the @publiclab/mapknitter-reviewers group
  • βœ… a ready label, once ready for final review by someone with merge permissions (@jywarren)
  • βœ… tests if possible (not mandatory but preferred) with each PR - although for first-timers this is less critical.

This doesn't mean that we should stop helping each other solve problems even if we're not in the reviewers' group -- We've seen a lot of great welcoming and cooperation! But at least we'll be able to get things ready and merged faster. πŸ‘ πŸ™Œ

Reviewers team

So, this new @publiclab/mapknitter-reviewers team -- we'd like to ask folks to join it if you're interested! Many of you already play this role -- THANK YOU! πŸŽ‰ We'd like folks to consider, as a prerequisite to joining:

  • βœ… having 2 PRs merged
  • βœ… having helped someone else troubleshoot a PR or issue
  • βœ… having made a first-timers-only issue and welcomed in a new person to make their own first contribution (this is how our community grows!)

If you've completed these, please ask here and we'll be sure to add you the new reviewers' group. You'll get notifications when people request a review from you, or mention @publiclab/mapknitter-reviewers.

Also, we welcome reviews by folks not in the reviewers' group, of course! This will be a group to help coordinate co-reviews, but it's not meant to be exclusive. And we encourage people to join!

Managing too many emails!

Just a note - your inbox can become quite a mess as the community grows! Consider turning off notifications for /every event/ and just listening to if you're mentioned! πŸ“¬

THANK YOU for making this part of the Public Lab coding community a warm, welcoming, and wonderful place!!! ⚑️ πŸ™Œ πŸ‘ πŸŽ‰ πŸŽ‰ πŸŽ‰

@jywarren
Copy link
Member

@publiclab/mapknitter-reviewers how do we feel about the above "policy" of 2+ approving reviews, with tests preferred, and using this policy to expand the group with merge privileges?

@cesswairimu
Copy link
Collaborator

Sounds good to me

@kaustubh-nair
Copy link
Member

@publiclab/mapknitter-reviewers how do we feel about the above "policy" of 2+ approving reviews, with tests preferred, and using this policy to expand the group with merge privileges?

Sounds like a good idea @jywarren

@sashadev-sky
Copy link
Member

Hi I completed the tasks :)

  1. FTO: Fix singularization case for "images"Β #636
  2. PRs Merged: Create Status.jsonΒ #483, Add remote_url to export modelΒ #552
  3. Troubleshooting: Adding rubocop sample configΒ #547

@sagarpreet-chadha
Copy link
Contributor

I would also love to join this team as well :-)

@cesswairimu
Copy link
Collaborator

I guess we can keep this open a little longer for other folks who would like to join. Thanks

@cesswairimu cesswairimu reopened this Jun 19, 2019
@jywarren
Copy link
Member

jywarren commented Jun 19, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants