Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump image-sequencer from 1.4.1 to 3.7.2/3 and switch uglifier to terser #1616

Merged
merged 8 commits into from
Mar 23, 2022
Merged

Bump image-sequencer from 1.4.1 to 3.7.2/3 and switch uglifier to terser #1616

merged 8 commits into from
Mar 23, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 22, 2022

Bumps image-sequencer from 1.4.1 to 3.7.2.

Release notes

Sourced from image-sequencer's releases.

v3.7.2 - node-png deprecation fix

This release compiles changes from v3.5.0 through v3.7.2 below, but has relatively smaller changes described in and coordinated from publiclab/image-sequencer#2037 :

Full changes since 3.5.0 include:

What's Changed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump image-sequencer from 1.4.1 to 3.7.2
ee87a30 
Bumps [image-sequencer](https://github.com/publiclab/image-sequencer) from 1.4.1 to 3.7.2.
- [Release notes](https://github.com/publiclab/image-sequencer/releases)
- [Commits](publiclab/image-sequencer@v1.4.1...v3.7.2)

---
updated-dependencies:
- dependency-name: image-sequencer
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file JavaScript labels Mar 22, 2022
@dependabot dependabot bot mentioned this pull request Mar 22, 2022
Closed
@gitpod-io
Copy link

gitpod-io bot commented Mar 22, 2022

@codeclimate
Copy link

codeclimate bot commented Mar 22, 2022

Code Climate has analyzed commit ee87a30 and detected 0 issues on this pull request.

View more on Code Climate.

@jywarren
Copy link
Member

darn, but unrelated:

error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads git://github.com/publiclab/leaflet-blurred-location
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Directory: /home/runner/work/mapknitter/mapknitter
Output:
fatal: remote error:
The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

@codecov
Copy link

codecov bot commented Mar 22, 2022 •
edited
Loading

Codecov Report

Merging #1616 (0690f62) into main (4331ef0) will decrease coverage by 1.08%.
The diff coverage is 59.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1616      +/-   ##
==========================================
- Coverage   72.98%   71.89%   -1.09%     
==========================================
  Files          40       40              
  Lines        1399     1409      +10     
==========================================
- Hits         1021     1013       -8     
- Misses        378      396      +18
Impacted Files Coverage Δ
app/channels/concurrent_editing_channel.rb 0.00% <0.00%> (-83.34%) ⬇️
app/controllers/utility_controller.rb 0.00% <0.00%> (-100.00%) ⬇️
app/helpers/users_helper.rb 21.73% <0.00%> (ø)
app/models/map.rb 92.25% <ø> (-1.30%) ⬇️
app/helpers/application_helper.rb 50.00% <20.00%> (ø)
app/controllers/annotations_controller.rb 59.25% <22.22%> (ø)
app/controllers/sessions_controller.rb 32.91% <22.22%> (ø)
app/controllers/front_ui_controller.rb 74.28% <33.33%> (ø)
app/controllers/application_controller.rb 88.88% <50.00%> (ø)
app/controllers/images_controller.rb 76.54% <61.90%> (ø)
... and 16 more

@jywarren
Copy link
Member

Minitest::UnexpectedError: RuntimeError: Wrapped undumpable exception for: ActionView::Template::Error: couldn't find file 'image-sequencer/dist/image-sequencer.js' with type 'application/javascript'

But republishing as v3.7.3 and it should work this time.

@jywarren
Copy link
Member

Hmm, some kind of sprockets Uglifier error:

Uglifier::Error: 
/home/runner/work/mapknitter/mapknitter/vendor/bundle/ruby/2.4.0/gems/uglifier-4.2.0/lib/uglifier.rb:291:in `parse_result'
/home/runner/work/mapknitter/mapknitter/vendor/bundle/ruby/2.4.0/gems/uglifier-4.2.0/lib/uglifier.rb:221:in `run_uglifyjs'
/home/runner/work/mapknitter/mapknitter/vendor/bundle/ruby/2.4.0/gems/uglifier-4.2.0/lib/uglifier.rb:166:in `compile'

@jywarren jywarren mentioned this pull request Mar 22, 2022
Merged
5 tasks
@jywarren jywarren changed the title Bump image-sequencer from 1.4.1 to 3.7.2 Bump image-sequencer from 1.4.1 to 3.7.2/3 Mar 22, 2022
@jywarren
Copy link
Member

Should test in GitPod to see the exact error, or try to?

@jywarren
Copy link
Member

Working backwards, it seems related to:

mapknitter/config/environments/production.rb

Line 29 in 4331ef0

config.assets.js_compressor = Uglifier.new(harmony: true, compress: { unused: false })

It had been this before:

config.assets.js_compressor = Uglifier.new(harmony: true)

Due to this es6 change: #917

Note there is a mention in lautis/uglifier#137 to use terser instead due to incomplete es6 support in uglifier.

We changed that here due to a known bug: #1192 (comment)

@jywarren jywarren changed the title Bump image-sequencer from 1.4.1 to 3.7.2/3 Bump image-sequencer from 1.4.1 to 3.7.2/3 and switch uglifier to terser Mar 23, 2022
@jywarren
Copy link
Member

Now LoadError: cannot load such file -- uglifier - will search for where this is

@jywarren jywarren force-pushed the dependabot/npm_and_yarn/image-sequencer-3.7.2 branch 2 times, most recently from 71c36eb to 0930fd2 Compare March 23, 2022 15:59
@jywarren jywarren mentioned this pull request Mar 23, 2022
Closed
@jywarren jywarren merged commit 1eecbc7 into main Mar 23, 2022
@jywarren
Copy link
Member

YAY

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/image-sequencer-3.7.2 branch March 23, 2022 19:15
@jywarren jywarren mentioned this pull request May 30, 2022
Open
This was referenced Jul 2, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jywarren