Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.15.2 to 2.18.0 #1884

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 27, 2023

Bumps rubocop-rails from 2.15.2 to 2.18.0.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.17.4

Bug fixes

  • #870: Fix an error for Rails/RootPathnameMethods when using Rails.env argument within Dir.glob. (@​koic)
  • #881: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash in multiline rescue branch before redirect_to. (@​gurix)
  • #871: Fix a false positive for Rails/WhereMissing when left_joins(:foo) and where(foos: {id: nil}) separated by or, and. (@​ydah)
  • #875: Make Rails/RootPathnameMethods aware of enforced style of Style/StringLiterals. (@​koic)
  • #882: Fix false positive for Rails/UniqueValidationWithoutIndex with :conditions option. (@​etiennebarrie)
  • #821: Enhance Rails/TimeZone to accept methods with the :in timezone option. (@​fatkodima)

Changes

RuboCop Rails 2.17.3

% cat relnotes/v2.17.3.md

Bug fixes

  • #843: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash in multiline if branch before redirect_to. (@​koic)
  • #841: Fix an error for Rails/ActionOrder when using unconventional order of multiple actions. (@​koic)
  • #838: Fix an incorrect autocorrect for Rails/ActionOrder when using unconventional order of actions in conditions. (@​koic)
  • #867: Fix autocorrection bug when ::Hash is used on Rails/IndexBy and Rails/IndexWith. (@​r7kamura)
  • #848: Fix a false positive for Rails/FreezeTime when using travel_to with an argument of Time.new(...).in_time_zone. (@​koic)
  • #869: Fix false-positives that non Rails formats are offended on Rails/ToSWithArgument. (@​r7kamura)
  • #866: Fix false-positives when constant is used with receiver on Rails/DurationArithmetic, Rails/IndexBy, Rails/IndexWIth, and Rails/RequireDependency. (@​r7kamura)
  • #850: Fix default configuration for Rails/I18nLazyLookup. (@​vlad-pisanov)
  • #837: Fix incorrect autocorrection of Rails/ActionOrder about comments. (@​r7kamura)
  • #855: Fix Rails/RootPathnameMethods autocorrection for Pathname calls without parens. (@​gsamokovarov)
  • #868: Support :: prefixed constants on Rails/ActionControllerFlashBeforeRender, Rails/ActionControllerTestCase, Rails/ApplicationController, Rails/ApplicationJob, Rails/ApplicationMailer, Rails/ApplicationRecord, Rails/DotSeparatedKeys, Rails/DynamicFindBy, Rails/FindEach, Rails/FreezeTime, Rails/HasManyOrHasOneDependent, Rails/HelperInstanceVariable, Rails/MailerName, Rails/MigrationClassName, Rails/Output, Rails/ReversibleMigrationMethodDefinition, Rails/ReversibleMigration, Rails/ShortI18n, Rails/SkipsModelValidations, and Rails/TimeZoneAssignment. (@​r7kamura)
  • #865: Support ::Rails and ::File on Rails/FilePath cop. (@​r7kamura)

Changes

  • #862: Ignore if number of arguments does not match on Rails/DynamicFindBy. (@​r7kamura)

RuboCop Rails 2.17.2

Bug fixes

... (truncated)

Changelog

Sourced from rubocop-rails's changelog.

2.18.0 (2023-02-25)

New features

Bug fixes

  • #824: Fix a false negative for Rails/ActionControllerTestCase when the class is namespaced. ([@​vlad-pisanov][])
  • #909: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash before redirect_to in if branch. ([@​koic][])
  • #898: Fix a false positive for Rails/ActiveRecordAliases when arguments of update_attributes is empty. ([@​koic][])
  • #920: Fix an error for Rails/NegateInclude when there is no receiver. ([@​fatkodima][])
  • #931: Fix error in Rails/Presence when ternary operators are used in multiple lines. ([@​r7kamura][])
  • #687: Fix Rails/HasManyOrHasOneDependent to correctly handle association methods with receiver. ([@​fatkodima][])
  • #929: Prevent Rails/SquishedSQLHeredocs applying when single-line comments are present. ([@​john-h-k][])
  • #887: Fix a false positive for Rails/NotNullColumn when adding a :virtual column. ([@​fatkodima][])
  • #918: Fix Rails/FreezeTime running against Rails < 5.2 apps. ([@​DRBragg][])
  • #895: Fix Rails/UnusedIgnoredColumns not recognizing columns added via +=. ([@​lucthev][])

Changes

  • #263: Accept actions defined via alias in Rails/LexicallyScopedActionFilter. ([@​fatkodima][])
  • #902: Ignore redirect method for Style/FormatStringToken by default. ([@​javierjulio][])
  • #935: Make Style/InverseMethods aware of Active Support's present?, blank?, include?, and exclude? methods. ([@​koic][])
  • #914: Make Style/InverseMethods aware of valid? and invalid? methods. ([@​koic][])
  • #826: Mark Rails/Pluck as unsafe. ([@​fatkodima][])
  • #896: Raise severity of Rails/ActiveRecordOverride, Rails/DeprecatedActiveModelErrorsMethods, Rails/DuplicateAssociation, Rails/DuplicateScope, Rails/TopLevelHashWithIndifferentAccess, and Rails/WhereNotWithMultipleConditions cops to warning. ([@​koic][])

2.17.4 (2022-12-25)

Bug fixes

  • #870: Fix an error for Rails/RootPathnameMethods when using Rails.env argument within Dir.glob. ([@​koic][])
  • #881: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash in multiline rescue branch before redirect_to. ([@​gurix][])
  • #871: Fix a false positive for Rails/WhereMissing when left_joins(:foo) and where(foos: {id: nil}) separated by or, and. ([@​ydah][])
  • #875: Make Rails/RootPathnameMethods aware of enforced style of Style/StringLiterals. ([@​koic][])
  • #882: Fix false positive for Rails/UniqueValidationWithoutIndex with :conditions option. ([@​etiennebarrie][])
  • #821: Enhance Rails/TimeZone to accept methods with the :in timezone option. ([@​fatkodima][])

Changes

2.17.3 (2022-11-20)

Bug fixes

  • #843: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash in multiline if branch before redirect_to. ([@​koic][])
  • #841: Fix an error for Rails/ActionOrder when using unconventional order of multiple actions. ([@​koic][])
  • #838: Fix an incorrect autocorrect for Rails/ActionOrder when using unconventional order of actions in conditions. ([@​koic][])

... (truncated)

Commits
  • fa6662f Cut 2.18.0
  • 1a791ec Update Changelog
  • c532db1 Fix a false negative for Rails/ActionControllerTestCase
  • e179054 Merge pull request #936 from koic/make_style_inverse_methods_aware_of_valid_a...
  • 9ff0c4d Merge pull request #937 from koic/fix_a_false_positive_for_rails_action_contr...
  • e9bb19f Suppress InternalAffairs/ProcessedSourceBufferName's offense
  • ad0fec1 [Fix #909] Fix a false positive for Rails/ActionControllerFlashBeforeRender
  • ecd9fbe [Fix #914] Make Style/InverseMethods aware of valid? and invalid? methods
  • 81b0fdc Merge pull request #935 from koic/make_style_inverse_methods_aware_of_active_...
  • b74740a Make Style/InverseMethods aware of some Active Support methods
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.15.2 to 2.18.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.15.2...v2.18.0)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Feb 27, 2023
@github-actions
Copy link

This is an automated pull request by @dependabot, a service we use to keep libraries up to date in our projects. Read this post to learn how to help us understand if it's ready to be merged (there are lots of considerations to balance!): https://bit.ly/3GphOhV

@codeclimate
Copy link

codeclimate bot commented Feb 27, 2023

Code Climate has analyzed commit aa842c9 and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants