leaflet v1.0

[jywarren]

Plus LeafletDistortableImage v0.1.3 -- using the new leaflet toolbar... !

[jywarren]

Testing this locally before merging

[jywarren]

@icarito - i can't seem to get this running on my local, due to some mysql issues. Can you either share a db dump w me or stand this up on a vm I can access so we can just test out the interface before merging this? Thanks.

[icarito]

I'm stuck here:

icarito@tycho:/srv/mapknitter_branch1/mapknitter$ docker-compose exec web rake assets:precompile                                              /usr/local/bin/ruby /usr/local/bin/rake assets:precompile:all RAILS_ENV=production RAILS_GROUPS=assets
rake aborted!
Sprockets::FileNotFound: couldn't find file 'leaflet-omnivore/leaflet-omnivore.min.js'
  (in /app/app/assets/javascripts/application.js:25)                                                                                          
Tasks: TOP => assets:precompile:primary
(See full trace by running task with --trace)
rake aborted!
Command failed with status (1): [/usr/local/bin/ruby /usr/local/bin/rake as...]

Tasks: TOP => assets:precompile
(See full trace by running task with --trace)                                                                                                 icarito@tycho:/srv/mapknitter_branch1/mapknitter$ 

[jywarren]

I'm very close here... i think we need:

• rmagick, gdal, and imagemagick -- and other prerequisites installed in the container as in the main MapKnitter container -- documented in the readme
  • this can then be tested at http://laboratoriopublico.org:11000/maps/test by uploading images to the map
• some resolution for the ReCaptcha problem, but this is not essential and can be addressed in followup
  • it keeps returning the error (roughly) recaptcha_tags not found even though I've run bundle install and confirmed gem list shows the recaptcha gem is installed.
  • docker-compose -f docker-compose.yml logs -f --tail=500 shows the error, when visiting http://laboratoriopublico.org:11000/maps/new

Then we should be all right!

[icarito]

Actually I was looking inside the container (with docker-compose exec web bash ) and I find gdal, imagemagick and rmagick are installed.

Further debugging from logs then:

[paperclip] saving warpables/1/censarbol.png
Completed 500 Internal Server Error in 500.1ms

TypeError (no implicit conversion of nil into String):
  app/controllers/images_controller.rb:83:in `+'
  app/controllers/images_controller.rb:83:in `url_upload_not_found'

[icarito]

Here's the full error log actually:

Started POST "/maps/titicaca/warpables" for 200.121.220.175 at 2018-01-06 13:43:15 +0000
Processing by ImagesController#create as JSON
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"sQazoNTqsTRXkCFXpmc8/XDK1L6DF1INIGSqwlhETl0=", "map_id"=>"titicaca", "uploaded_data"=>#<ActionDispatch::Http::UploadedFile:0x0055bc4fdea8a8 @original_filename="censarbol.png", @content_type="image/png", @headers="Content-Disposition: form-data; name=\"uploaded_data\"; filename=\"censarbol.png\"\r\nContent-Type: image/png\r\n", @tempfile=#<Tempfile:/tmp/RackMultipart20180106-8-rbl607>>}
Command :: file -b --mime '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-x6t5m5.png'
Command :: identify -format '%wx%h,%[exif:orientation]' '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn.png[0]' 2>/dev/null
Command :: identify -format %m '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn.png[0]'
Command :: convert '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn.png[0]' -auto-orient -resize "500x375" '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn20180106-8-1kteqjb'
Command :: file -b --mime '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn20180106-8-1kteqjb'
Command :: identify -format '%wx%h,%[exif:orientation]' '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn.png[0]' 2>/dev/null
Command :: identify -format %m '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn.png[0]'
Command :: convert '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn.png[0]' -auto-orient -resize "240x180" '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn20180106-8-15uzgic'
Command :: file -b --mime '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn20180106-8-15uzgic'                                          Command :: identify -format '%wx%h,%[exif:orientation]' '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn.png[0]' 2>/dev/null
Command :: identify -format %m '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn.png[0]'
Command :: convert '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn.png[0]' -auto-orient -resize "100x100>" '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn20180106-8-aafaf0'
Command :: file -b --mime '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-c9n8yn20180106-8-aafaf0'
Command :: file -b --mime '/tmp/5574b1622fa9ee7e60978a6064b5b09d20180106-8-1xh8wmu.png'
[paperclip] saving warpables/1/censarbol.png
Completed 500 Internal Server Error in 500.1ms

TypeError (no implicit conversion of nil into String):
  app/controllers/images_controller.rb:83:in `+'
  app/controllers/images_controller.rb:83:in `url_upload_not_found'

[icarito]

Going to run each of those commands by hand and see what is.

[icarito]

Okay here's what I have learned from running each of the Imagemagick commands by hand: All of the commands work, excepting the first and last file commands which oddly are looking for a different filename than the operations in between. Looks like a bug to me.

[icarito]

Actually it's confusing because I see no difference with production logs, in production logs look the same, without the 500. I'll try temporary disabling the exception rescue procedure in app/controllers/images_controller.rb to see where the actual error is.

[icarito]

Aha!:

Errno::ENOENT (No such file or directory @ rb_sysopen - config/amazon_s3.yml):                                                                                                   
  app/controllers/images_controller.rb:51:in `block in create'                                                                                                                   
  app/controllers/images_controller.rb:50:in `create'                                                                                                                            

[icarito]

Naively I put a dummy .yml amazon config file but found:

AWS::Errors::MissingCredentialsError
Missing Credentials.
Unable to find AWS credentials.  You can configure your AWS credentials
a few different ways:                                                                                                                                                                                     

Created #245 to document how to setup without relying on the big A.

[icarito]

Level up, next error:

Completed 500 Internal Server Error in 393.5ms                                                                                                                                                                                                                                                                                                                    Paperclip::AdapterRegistry::NoHandlerError (No handler found for "/system/images/1/original/sand_tileset.png"):                                                                  
  app/models/warpable.rb:49:in `save_dimensions'                                                                                                                                   app/controllers/images_controller.rb:51:in `block in create'                                                                                                                     app/controllers/images_controller.rb:50:in `create'                                                                                                                            

[icarito]

Commented this out too, need better fix (related to #245):

#if Rails.env.production?
#  geo = Paperclip::Geometry.from_file(Paperclip.io_adapters.for(self.image.url)) # s3 version
#else
geo = Paperclip::Geometry.from_file(Paperclip.io_adapters.for(self.image).path) # local filesystem version
#end

[jywarren]

Awesome, good catch!

…

On Jan 8, 2018 8:58 AM, "Sebastian Silva" ***@***.***> wrote: Commented this out too, need better fix (related to #245 <#245>): #if Rails.env.production? # geo = Paperclip::Geometry.from_file(Paperclip.io_adapters.for(self.image.url)) # s3 version #else geo = Paperclip::Geometry.from_file(Paperclip.io_adapters.for(self.image).path) # local filesystem version #end — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#243 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJy10SNDIAGdNUdxEN6ebEbs8wjWwks5tIh7zgaJpZM4RT0DW> .

[icarito]

Okay please test http://laboratoriopublico.org:11000/maps/test

[jywarren]

It works perfectly! Now we need to resolve the recaptcha issue and we should be good. It's great to see this new version live!

…

On Jan 8, 2018 9:02 AM, "Sebastian Silva" ***@***.***> wrote: Okay please test http://laboratoriopublico.org:11000/maps/test — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#243 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJzpMv1JvCBoxz1YZzQ3Rkdkx2B8Sks5tIh-6gaJpZM4RT0DW> .

[jywarren]

Oy, i still can't make any progress on this recaptcha thing. Not hyper urgent but if you have any great detective insights, I think that's the last thing!

[jywarren]

http://laboratoriopublico.org:11000/maps/new

[jywarren]

I believe this is ready for deployment to MapKnitter.org -- it'll need bower install, bower update, bundle update -- and this line (and key name changes) will need to be added to the recaptcha.rb file:

https://github.com/jywarren/mapknitter/blob/e28933a5f6dbcdfc539002fadcc9eac57a6ed313/config/initializers/recaptcha.rb#L3-L5