Attempt to install codecov #543
Conversation
|
Code Climate has analyzed commit d1c116f and detected 0 issues on this pull request. View more on Code Climate. |
|
Are we switching to codecov instead of coveralls? |
|
We tried it out in image-sequencer and it was very smooth, so I thought we
could try it here too. Do you prefer it?
…On Tue, Apr 16, 2019, 8:59 AM Kaustubh Nair ***@***.***> wrote:
Are we switching to codecov instead of coveralls?
This would be great! We wouldn't have security issues of making the token
public
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#543 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ7z7pr2FznJNKFIjB5Nxa0FI0Yj7ks5vhckkgaJpZM4cxQfJ>
.
|
|
I can't get it to make comments like it did on image sequencer... |
|
Oh I guess I need to install a gem or something? |
|
Working from publiclab/image-sequencer#1014 |
|
Looks like you forgot to modify the travis file |
|
Oh you just did 😄 |
|
Travis logs say, |
@jywarren @kaustubh-nair Yes, in order to get this working we need to install simplecov gem and set it up in our |
|
Okay, let's do it |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Gemfile
Outdated
| @@ -41,6 +41,7 @@ end | |||
|
|
|||
| group :test do | |||
| gem 'test-unit' | |||
| gem "simplecov", require: false | |||
There was a problem hiding this comment.
Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem simplecov should appear before test-unit.
Gemfile
Outdated
| @@ -41,6 +41,7 @@ end | |||
|
|
|||
| group :test do | |||
| gem 'test-unit' | |||
| gem "simplecov", require: false | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
Rubocop is being really strict :/ |
I got a sample yml I used in previous projects, I'll MR it and we could discuss its rules we'd want. Done this in #547 |
|
awesome, folks! Yeah, Rubocop is also just not very nice when it leaves
comments... "violations" isn't very friendly! let's turn it way down until
we can tune it a bit.
…On Tue, Apr 16, 2019 at 11:43 PM Kaustubh Nair ***@***.***> wrote:
Rubocop is being really strict :/
We should add a config file and remove whatever config options we don't
need
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#543 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ0_s2Ep46dV5p3F279tD8ZoJ0sguks5vhpg7gaJpZM4cxQfJ>
.
|
|
I added the gem but it still doesn't seem to be sending the reports |
Codecov Report
@@ Coverage Diff @@
## main #543 +/- ##
======================================
Coverage ? 69.4%
======================================
Files ? 31
Lines ? 1242
Branches ? 0
======================================
Hits ? 862
Misses ? 380
Partials ? 0 |
|
yay! 😄 |
|
The coverage report was not accessible from inside the docker container. So I created a shared volume to store the report there. |
|
It seems the docker volume was not necessary after all.. |
|
Oooh what a pretty graph! Merging this!!!!! |
|
@cesswairimu check it out! 👀 |
|
@publiclab/plots2-reviewers @publiclab/reviewers would we like this to be installed on |
|
Wow this looks amazing @jywarren @kaustubh-nair 🎉 🎉 . How do I get it to comment on my PR just rebased but can't see the bot 👀 |
|
My bad, I see the bot now 😃 |
* Attempt to install codecov * Create .codecov.yml * Update .travis.yml * Add simplecov * Add docker volume and change formatter * Remove unneccessary files and fix rubocop issues * Remove coveralls and add more filters * modify gitignore * add .simplecov file * remove docker volume
#467 #491 #531