User cant subscribe to tags.

[rishabhptr]

Please describe the problem (or idea)

subscribe/tag/'anything' leads to an error page.

[jywarren]

uh oh! I think that's supposed to be `.length.positive?` -- to make sure it's more than zero! Can you open a PR for this? This is pretty urgent! Great catch!

…

On Sun, Feb 4, 2018 at 6:19 AM, Rishabh Singh ***@***.***> wrote: Please describe the problem (or idea) subscribe/tag/'anything' leads to an error page. [image: screenshot from 2018-02-04 16-47-49] <https://user-images.githubusercontent.com/26951824/35776919-2a7f8512-09cb-11e8-9dbe-55233f56e750.png> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2224>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ08LtTy5TSP2cOJkqKqPioPjZidBks5tRZIqgaJpZM4R4iGD> .

[rishabhptr]

@jywarren I have #2225 open for this where I was using .any? to check if any relation exists but 'length.positive?' works too , so I have updated the pr 😄 .

[jywarren]

awesome, thank you!

…

On Mon, Feb 5, 2018 at 11:34 AM, Rishabh Singh ***@***.***> wrote: @jywarren <https://github.com/jywarren> I have #2225 <#2225> open for this where I was using .any? to check if any relation exists but 'length.positive?' works too , so I have updated the pr 😄 . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2224 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ7eEpz3jKMQyarhP4B9WpUaC3HwLks5tRy2JgaJpZM4R4iGD> .

[jywarren]

Actually shall we create a test for this method, so we don't miss this again?

[rishabhptr]

@jywarren Yes , I'd love to help! :)

[jywarren]

That'd be great -- here's the file where it ought to go -- we don't have a lot of tests in there! https://github.com/publiclab/plots2/blob/master/test/functional/subscription_controller_test.rb

If you want to open a new issue for this that'd be great, or just go for a PR -- either way! Thank you so much! 👍