Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Search by tag" text entry to the top of https://publiclab.org/contributors #2720

Closed
ebarry opened this issue May 11, 2018 · 5 comments
Closed

Comments

@ebarry
Copy link
Member

ebarry commented May 11, 2018

Please describe the idea

What problem could this idea solve?

https://publiclab.org/contributors makes sense as the home for contributors on publiclab.org. But right now, it only has 5 hard coded topic areas.

What did you expect to see that you didn't?

I would like to see a "Search by tag" text box such as what is already at the top of https://publiclab.org/tags (or the tag search on https://publiclab.org/questions that actually seems to have an autosuggest that preforms better than the version on /tags -- does this need to be broken out as another issue?) that would result in seeing the very nice contributor page for a tag, for example: https://publiclab.org/contributors/pm.

A second thing i expect to see is that contributor pages have the same header across all tabs, described in #2718

Please show us where to look

https://publiclab.org/ ...

What's your PublicLab.org username?

This can help us diagnose the issue:

liz

@ebarry ebarry added this to the Tagging and topics milestone May 11, 2018
@rtrunkhill
Copy link
Contributor

I resolved this issue:
image

but im having issues passing any tests right now. as soon as i get that resolved i'll submit the pr here

@jywarren
Copy link
Member

jywarren commented Jun 20, 2018 via email

@rtrunkhill
Copy link
Contributor

I'm getting the same issue as here with this test:

  test "should use existing node body as template in post form based on param 'n'" do
    UserSession.create(users(:bob))

    get :new,
        params: { 
        tags: 'one,two',
        n: nodes(:blog).id
        }

    assert_response :success
    assert_select '#taginput[value=?]', 'one,two'
    assert_select 'textarea#text-input', nodes(:blog).body
  end

if i take that test out, it passes all the tests. so i'll submit and see what you guys want to do with it. also see the syntax error in the bottom right %[count} ?

image

I tried to make the change to config/locales/views/tag/contributors/en.yml on line 12 people_watching_tag: "%{count} people are watching this tag" but for a reason i havn't figured out yet, i'm can't seem to make changes to that file. that syntax error is live in production

@ebarry
Copy link
Member Author

ebarry commented Jan 2, 2019

hi all! Excited to see this progress. I do see the syntax error is still happening. Also, the "Search by tag" box has not yet been added at the top. Anything i can do to help?

@jywarren
Copy link
Member

A lot of this functionality has been moved into the /stats system and the graphs are no longer available. I'm going to close this but can discuss further if needed! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants