Rails 5 follow-up fixes

[jywarren]

Just compiling some things from the #2726 #278 Rails 5 upgrades now that it's in stable!

• POST https://stable.publiclab.org/tag/suggested/tag 404 (Not Found) - did route change? A GET route exists:

  plots2/config/routes.rb

  Line 173 in 9172df4

  get 'tag/suggested/:id' => 'tag#suggested'

• top navbar search autocomplete doesn't work (doesn't seem to trigger a request at all?) (existing bug!)

@Souravirus any help appreciated but I imagine it's late there!

[Souravirus]

Yeah lets check what has happened

[jywarren]

Oh wait! The top bar nav search does work on a note page! But not on a /post page. Let's test more!

[Souravirus]

I was checking on the dashboard and it was working fine there. That's why I said in gitter

[jywarren]

Ha, and yes, https://publiclab.org/post also doesn't autocomplete. so that's an existing bug! Removing it from above.

[Souravirus]

yeah its not auto completing but the search is working fine here

[jywarren]

Also Travis seems to have trouble with this... the post-merge run failed with some kind of timeout very early in the process: https://travis-ci.org/publiclab/plots2/builds/389444495 -- adding to list, but @icarito any idea why it would get stuck on:

Step 1/16 : FROM ruby:2.4.1-jessie
2.4.1-jessie: Pulling from library/ruby
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

[Souravirus]

yeah there was timeout sometimes but restarting the build worked

[jywarren]

OK - can you change the GET to a POST and open a PR? That's the only thing I've found now!

[Souravirus]

Ok I will change 'get' to 'post'

[jywarren]

Just going to re-open this for a question -- locally, I'm seeing:

ActiveRecord::StatementInvalid (Mysql2::Error: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'plots.node_revisions.vid' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by: SELECT  `node_revisions`.* FROM `node_revisions` INNER JOIN `node` ON `node`.`nid` = `node_revisions`.`nid` WHERE (type = ('page')) AND (node.status = 1) AND (node_revisions.status = 1) AND (timestamp - node.created > 300) GROUP BY node.title ORDER BY timestamp DESC LIMIT 10):
  
app/controllers/home_controller.rb:127:in `activity'
app/controllers/home_controller.rb:163:in `block in set_activity'
app/controllers/home_controller.rb:162:in `set_activity'
app/controllers/home_controller.rb:15:in `home'

Did you ever see this error? Thanks!

[Souravirus]

No I haven't seen this error.

[Souravirus]

behind this error

[Souravirus]

Hi @jywarren according to this stackoverflow post https://stackoverflow.com/questions/34115174/error-related-to-only-full-group-by-when-executing-a-query-in-mysql since we are doing group by by a node.title, that's why it is giving that error. We should try adding group by node.id then it would be perfect.

[jywarren]

oh cool! Want to try opening a PR?

…

On Fri, Jun 8, 2018 at 1:15 PM Sourav Sahoo ***@***.***> wrote: Hi @jywarren <https://github.com/jywarren> according to this stackoverflow post https://stackoverflow.com/questions/34115174/error-related-to-only-full-group-by-when-executing-a-query-in-mysql since we are doing group by by a node.title, that's why it is giving that error. We should try adding group by node.id then it would be perfect. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2787 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJz713FmM_MvGeLKFCYma3IjoNjGZks5t6rEagaJpZM4UfKnr> .

[Souravirus]

Yeah I will open a PR