Sending an answer inserts answer text into other textareas on the page

[jywarren]

I entered an answer and posted it on this page: https://publiclab.org/questions/warren/10-29-2018/help-us-refine-the-search-interface-at-publiclab-org

My answer was posted, but strangely, its comment box also contained my original answer text, and the text also remained in the answer posting textarea:

I would guess there's something going wrong with the ids of these textareas that is causing the content to be inserted incorrectly:

plots2/app/views/questions/_answers.html.erb

Lines 9 to 14 in 46235a7

	<div id="post-answer">
	<% if current_user %>
	<%= render :partial => "comments/form", :locals => { title: "Post an answer", comment: false, placeholder: "Help users by posting an answer to this question", is_answer: true } %>
	<% else %>
	<p><%= link_to "Sign up", signup_path( return_to: request.path )%> or <%= link_to "Login", new_user_session_path( return_to: request.path )%> to post an answer to this question.</p>
	<% end %>

Notice how the answer posting form re-uses the comment form. Perhaps there is a collision of unique IDs between these.

[SidharthBansal]

Published on GCI dashboard

[oorjitchowdhary]

I can't find this task on the gci dashboard.. is it already solved?

[oorjitchowdhary]

@SidharthBansal @jywarren

[handlerug]

I solved it in PR #4049, please, check it :)

[grvsachdeva]

Hey @jywarren @handlerug while reviewing PR created by @handlerug , i was trying to replicate the error and found that this error is not due to unique id problem or so, but somewhat related to comment template. Like, when I created a test question on the website and added tag as comment-template:ui-feedback-template. All text areas got this template.

Information about comment templates - https://publiclab.org/comment-templates

Test question - https://publiclab.org/questions/gauravano/11-26-2018/test-question

Thanks!

[handlerug]

It's problem with response from the server. When user submits comment, server returns filled answer template with new comment form prefilled with answer text. So I added special flag to disable auto-filling and now it's working fine.

I will do some extra checks today and will try to solve it, thanks! 👍

[jywarren]

Awesome!!!

…

On Mon, Nov 26, 2018, 8:51 PM handlerug ***@***.*** wrote: It's problem with response from the server. When user submits comment, server returns filled answer template with new comment form prefilled with answer text. So I added special flag to disable auto-filling and now it's working fine. I will do some extra checks today and will try to solve it, thanks! 👍 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3836 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ7XObKbtCzi1cT0tCZTgTSODetS2ks5uzJqUgaJpZM4YAtsG> .

[handlerug]

It's problem inside new comment view, so I fixed it already. Can you check it again @jywarren @gauravano?

[grvsachdeva]

@jywarren don't you think the issue you mentioned was due to the tag comment-template:ui-feedback-template in https://publiclab.org/questions/warren/10-29-2018/help-us-refine-the-search-interface-at-publiclab-org. See https://publiclab.org/comment-templates for more details. If you think the issue you faced was due to tag and it's the natural function of tag, then it's possibility that we might have intruded in comment-template tag's working by merging PR #4049 . Thanks!

[jywarren]

Hmm, it's worth watching this carefully. I don't think the original issue was related to the comment template feature. So i think this is OK. But let's keep an eye out. I also haven't seen the local_assigns usage that the solution in #4049 has, so maybe i'm not quite sure what's going on. Let's watch the production server to be sure comment-templates still work, as in https://publiclab.org/questions/warren/10-29-2018/help-us-refine-the-search-interface-at-publiclab-org

@handlerug i'm going to be publishing new code in about an hour. Would you be able to test and ensure both features are working? Thanks!

[handlerug]

I think comment templates will be broken because I ever didn't know about this feature and my fix removes any text from comment form inside answer view. I will check it in two hours, can I add more commits to my pull request? Thanks!

[jywarren]

Ah - well you can open a new PR with additional changes! No worries -- thanks for following up!

…