Questions page Comment and Answer numbers not changing correctly

[kevinzluo]

Please describe the problem (or idea)

What did you expect to see that you didn't?

Deleting a comment to an answer decreases the answer count:

---

Posting a new comment increases answer count.

---

Adding an answer doesn't increase answer count, but deleting one does.

Please show us where to look

https://publiclab.org/questions

What's your PublicLab.org username?

This can help us diagnose the issue:

kevinz_qu

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

Chrome, Ubuntu

---

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

The problems I mentioned all go away when the page is refreshed.

I would like to try working on this issue.

[conkytom]

I'd like to take a look at this.

[kevinzluo]

Hi @conkytom
I actually started working on this already. Maybe we can assist each other 😄.

[conkytom]

Hey @kevinzluo, I haven't pinned down the source of the problem. I only just started comparing the code from comments in Notes to comments in questions. I was going to look at it more closely and try different approaches tomorrow. If you've got any insights or want another set of eyes on it let me know.

[kevinzluo]

I think we should try moving everything to use notes/comments. It seems like questions/comments has become deprecated and lacks the "Promote comment to answer" button after #3195. I'll let you know if I can find anything else.
Thanks!

[jywarren]

I think Kevin is right, here! Perhaps it could be removed if deprecated :-)

…

On Sun, Nov 25, 2018 at 10:09 PM kevinzluo ***@***.***> wrote: I think we should try moving everything to use notes/comments. It seems like questions/comments has become deprecated and lacks the "Promote comment to answer" button after #3195 <#3195>. I'll let you know if I can find anything else. Thanks! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4034 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ-AZJrvAMDiqDcblwKB_otnIX8qpks5uy1tbgaJpZM4YxKlz> .

[conkytom]

Been working on updating the question views using notes as the template, but I'm still getting weird numbers when entering comments of deleting answers. Often entering one comment will create 4 duplicates at the same time, however refreshing the page removes the duplicates and fixes any counting discrepancies.

Here's what I've changed so far, if it's not too disruptive to what you've been working on it might be useful to you. conkytom@e0b29ad

[kevinzluo]

Hi sorry for the delay, I've been busy studying for my exam which is tomorrow. After, I take it I will return to working.

Sorry!

[jywarren]

Closing as we've merged comments and answers now! Thanks!