Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up en.yml #4997

Closed
5 tasks
cesswairimu opened this issue Mar 10, 2019 · 7 comments
Closed
5 tasks

Clean up en.yml #4997

cesswairimu opened this issue Mar 10, 2019 · 7 comments
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@cesswairimu
Copy link
Collaborator

Created specifically for @Anjalizi

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

Problem: With the new dynamic stats page there are a few thing we are not using on https://github.com/publiclab/plots2/blob/master/config/locales/en.yml
Lets clean up this

  • 📝 Update:
    Remove this blocks of code

After changing this, attach the screenshot of /stats in the PR. Just to make sure we didn't break anything on this page

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Thanks!

@cesswairimu cesswairimu added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Mar 10, 2019
@cesswairimu
Copy link
Collaborator Author

@Anjalizi here you go.

@Anjalizi
Copy link
Contributor

thank you. I shall start with this :)

@Jaya738
Copy link

Jaya738 commented Mar 11, 2019

Is there anyone already done with this

@Jaya738
Copy link

Jaya738 commented Mar 11, 2019

please review my changes and accept the pull request

@cesswairimu
Copy link
Collaborator Author

cesswairimu commented Mar 11, 2019

Sorry @Jaya738, @Anjalizi is working on this one

@grvsachdeva
Copy link
Member

hey @cesswairimu, thank you for opening FTOs, please also update the list - #4963 (comment) whenever you create a FTO for a contributor so all of us can know. Thanks again 💯

@jywarren
Copy link
Member

jywarren commented Mar 11, 2019 via email

@Anjalizi Anjalizi mentioned this issue Mar 11, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

No branches or pull requests

5 participants