Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get parent tags to display child tag content in graphs #918

Closed
jywarren opened this issue Oct 24, 2016 · 7 comments
Closed

Get parent tags to display child tag content in graphs #918

jywarren opened this issue Oct 24, 2016 · 7 comments
Labels
enhancement explains that the issue is to improve upon one of our existing features help wanted requires help by anyone willing to contribute Ruby

Comments

@jywarren
Copy link
Member

We've just created a tag aliasing system in #871, so that content tagged with spectrometer, which has a tag.parent of spectrometry, appears on the spectrometry (parent) tag page:

https://publiclab.org/tag/spectrometry

However, the graph shown on that page does not show spectrometer-tagged content, just the listing below does. Let's fix it in the graph, so the graph should include all data shown on the graph shown at https://publiclab.org/tag/spectrometer.

I believe the graph draws on data from these two methods: https://github.com/publiclab/plots2/blob/master/app/models/drupal_tag.rb#L143-L169

Yes - the call to tag.weekly_tallies is here: https://github.com/publiclab/plots2/blob/master/app/views/tag/show.html.erb#L20

@jywarren jywarren added enhancement explains that the issue is to improve upon one of our existing features help wanted requires help by anyone willing to contribute Ruby labels Oct 24, 2016
@manish310794
Copy link
Collaborator

@jywarren What if the hierarchy goes like this spectometry <- spectometer <- sub-category? Will the spectrometer tag page show content with tags spectometer and sub-category as well?

@jywarren
Copy link
Member Author

Hi! No, I think only one level... To do more could lead us to circular and
infinite queries, right?

Thanks!

On Oct 28, 2016 9:29 AM, "Manish Agarwal" notifications@github.com wrote:

@jywarren https://github.com/jywarren What if the hierarchy goes like
this spectometry <- spectometer <- sub-category? Will the spectrometer
tag page show content with tags spectometer and sub-category as well?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#918 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ4FkrP2A5bM0FV2LY0ZU0vM3Unufks5q4iLRgaJpZM4KfLzM
.

@manish310794
Copy link
Collaborator

Yes, you are right. It might lead to circular queries since it not a strict category-sub-category system.

@jywarren
Copy link
Member Author

Hi, were you interested in taking this issue on? I'd be happy to offer some more input if so.

@manish310794
Copy link
Collaborator

@jywarren Yes I am interested to take this up.

@jywarren
Copy link
Member Author

Super! Tell me if you need anything and thanks!

On Oct 31, 2016 1:13 AM, "Manish Agarwal" notifications@github.com wrote:

@jywarren https://github.com/jywarren Yes I am interested to take this
up.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#918 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJzkLUzp1ZuKZ49N2lAlmch-Z3-PDks5q5Xj9gaJpZM4KfLzM
.

@jywarren
Copy link
Member Author

jywarren commented Oct 1, 2019

Reworking this into a plan to do some auto-tagging! #6367

@jywarren jywarren closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement explains that the issue is to improve upon one of our existing features help wanted requires help by anyone willing to contribute Ruby
Projects
None yet
Development

No branches or pull requests

2 participants