Bump leaflet-environmental-layers from 2.4.3 to 2.4.4

[dependabot]

Bumps leaflet-environmental-layers from 2.4.3 to 2.4.4.

Commits

• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[gitpod-io]

[codeclimate]

Code Climate has analyzed commit 4f9452a and detected 0 issues on this pull request.

View more on Code Climate.

[codecov]

Codecov Report

Merging #10033 (4f9452a) into main (f41f8e7) will decrease coverage by 0.07%.
The diff coverage is 82.14%.

@@            Coverage Diff             @@
##             main   #10033      +/-   ##
==========================================
- Coverage   82.13%   82.06%   -0.08%     
==========================================
  Files          98       98              
  Lines        5968     5976       +8     
==========================================
+ Hits         4902     4904       +2     
- Misses       1066     1072       +6     

Impacted Files	Coverage Δ
app/models/tag.rb	93.26% <44.44%> (-4.27%)	⬇️
app/controllers/images_controller.rb	70.27% <100.00%> (ø)
app/controllers/notes_controller.rb	85.09% <100.00%> (+0.22%)	⬆️
app/controllers/tag_controller.rb	80.42% <100.00%> (ø)
app/helpers/application_helper.rb	87.62% <100.00%> (+2.21%)	⬆️
app/services/search_service.rb	95.00% <100.00%> (-0.10%)	⬇️
app/controllers/user_tags_controller.rb	83.78% <0.00%> (+1.35%)	⬆️

[daemon1024]

It doesn't seem to fix things here :
We might need to fix it as part of the plots2 codebase probably

[jywarren]

Can you see if the response from the API is giving each user a url parameter? That's what LBLD uses to determine if the list should be generated.

[daemon1024]

 {
      "doc_id": 768638,
      "doc_type": "PLACES",
      "doc_url": "/profile/charliejohnson",
      "doc_title": "charliejohnson",
      "doc_score": null,
      "doc_author": null,
      "doc_image_url": "https://www.gravatar.com/avatar/6e62cf8e8246c20b6b9839c175dc996a",
      "latitude": "0",
      "longitude": "0",
      "blurred": true,
      "category": "PLACES",
      "place_name": null,
      "created_at": "2021-08-10T11:07:07.000Z",
      "time_since": null,
      "comment_count": null
    }

No url parameter, but there's doc_url. You meant to check the nearbyPeople API right?

[daemon1024]

But other than that, the core issue, to not generate markers outside of the boxes where no peeps are. That's not fixed

[daemon1024]

https://github.com/publiclab/plots2/pull/10033/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deR7950 I don't think the LBLD update is part of this. I don't see it updated as part of yarn.lock

[jywarren]

Was this wrong then? Should we be checking for doc_url instead?

https://github.com/publiclab/leaflet-blurred-location-display/pull/123/files#diff-bb7057786681c1b27cba6e74b63c1dda96628c78f37e2ddc039860644f674715R78

No, because we translate it here:

https://github.com/publiclab/leaflet-blurred-location-display/blob/76e5489c9560b67fe090f833d2c41dbe47781290/src/blurredLocationDisplay.js#L57

Hmm. Where do you think this is breaking down?

[daemon1024]

Since github is not letting me post review for that particular line. I am attaching the screenshot highlighting the line.

LBLD should 1.3.1 but it's 1.1 here

[jywarren]

Ah but wait - are you looking in a place where there are blurred location users? Let me try...

The other issue is on not showing a /popup/ right, not a marker?

[daemon1024]

@jywarren I don't think there's an issue with the code. The issue is our updates are not part of this pull request. Ref #10033 (comment)

[jywarren]

Ah, now i see what the screenshot was showing! OK, let's see why. Also, confirming that an "empty" but shaded square that should have no marker but the popup should show a list:

[jywarren]

Yes, ok, let's make it a requirement here: https://github.com/publiclab/leaflet-environmental-layers/blob/main/package.json#L74

[jywarren]

I need to update the package-lock.json too, then I'll publish LEL 2.4.5, ok!?

[daemon1024]

Sure, sounds good to me.

[jywarren]

OK, so this will be superceded by the new version, but let's check the same region for the popup. Then we can make a new issue in LBLD for not making a popup if there are no subitems, if needed.

[daemon1024]

Then we can make a new issue in LBLD for not making a popup if there are no subitems, if needed.

I believe that's already handled in https://gihub.com/publiclab/leaflet-blurred-location-display/pull/123/ right?

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

[jywarren]

https://www.npmjs.com/package/leaflet-environmental-layers done! v2.4.5

[jywarren]

Triggered dependabot. Now waiting for new PR! #10034