Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unflag-tooltip to claify button #10876

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

stephaniequintana
Copy link
Contributor

Fixes #10839 (the PR fix for the original issue) and #10820 (the original issue)

added data-toggle="tooltip" data-placement="top" title="Remove all flags"
to the existing "unflag" button:

<a class="btn btn-xs border-curve font-weight-bold btn-warning unflag"
  data-remote="true"href="/moderate/remove_flag_node/<%= flag.id %>">Unflag</a>

The changes will be applied to the following:

Screen Shot 2022-03-30 at 2 49 41 PM

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

This PR was created in reference for the original PR, #10839, as the branch (and corresponding repo) has been deleted and is unrecoverable.

@gitpod-io
Copy link

gitpod-io bot commented Mar 30, 2022

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #10876 (4d26738) into main (f118e45) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 4d26738 differs from pull request most recent head 88efbd6. Consider uploading reports for the commit 88efbd6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10876      +/-   ##
==========================================
- Coverage   82.45%   82.34%   -0.12%     
==========================================
  Files          98       98              
  Lines        5991     5991              
==========================================
- Hits         4940     4933       -7     
- Misses       1051     1058       +7     
Impacted Files Coverage Δ
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.87% <0.00%> (-3.83%) ⬇️

@codeclimate
Copy link

codeclimate bot commented Apr 1, 2022

Code Climate has analyzed commit 88efbd6 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5896793499/artifacts/200480495

@stephaniequintana
Copy link
Contributor Author

Resolved #10839 (the PR fix for the original issue) and #10820 (the original issue)

@TildaDares
Copy link
Member

TildaDares commented Apr 5, 2022

Hi @stephaniequintana, why did you close this PR?

@stephaniequintana
Copy link
Contributor Author

@TildaDares, I did - my apologies. When you asked that I close #10839 because this one resolved the issue, I see that I had mistakenly closed this one as well. Shall I reopen it now?

@TildaDares
Copy link
Member

Sure, you can reopen it.

@stephaniequintana
Copy link
Contributor Author

Reopening due to premature close.

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5946241036/artifacts/203843161

@TildaDares TildaDares merged commit cc08d12 into publiclab:main Apr 7, 2022
@welcome
Copy link

welcome bot commented Apr 7, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@TildaDares
Copy link
Member

Congratulations @stephaniequintana 🎉

@stephaniequintana stephaniequintana deleted the unflag-tooltip-branch branch April 7, 2022 19:54
@stephaniequintana
Copy link
Contributor Author

Thank you, @TildaDares - that was a journey! So glad to finally be a "contributor"!! 🥳 🎆

@TildaDares
Copy link
Member

@stephaniequintana Coding is not the only form of contribution. Your support for other applicants and creating FTOs are all valid contributions ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants