-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added unflag-tooltip to claify button #10876
added unflag-tooltip to claify button #10876
Conversation
Codecov Report
@@ Coverage Diff @@
## main #10876 +/- ##
==========================================
- Coverage 82.45% 82.34% -0.12%
==========================================
Files 98 98
Lines 5991 5991
==========================================
- Hits 4940 4933 -7
- Misses 1051 1058 +7
|
Code Climate has analyzed commit 88efbd6 and detected 0 issues on this pull request. View more on Code Climate. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Hi @stephaniequintana, why did you close this PR? |
@TildaDares, I did - my apologies. When you asked that I close #10839 because this one resolved the issue, I see that I had mistakenly closed this one as well. Shall I reopen it now? |
Sure, you can reopen it. |
Reopening due to premature close. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Congratulations @stephaniequintana 🎉 |
Thank you, @TildaDares - that was a journey! So glad to finally be a "contributor"!! 🥳 🎆 |
@stephaniequintana Coding is not the only form of contribution. Your support for other applicants and creating FTOs are all valid contributions ❤️ |
Fixes #10839 (the PR fix for the original issue) and #10820 (the original issue)
added
data-toggle="tooltip" data-placement="top" title="Remove all flags"
to the existing "unflag" button:
The changes will be applied to the following:
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowThis PR was created in reference for the original PR, #10839, as the branch (and corresponding repo) has been deleted and is unrecoverable.