Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverted negation in if/else statement #11483

Closed
wants to merge 1 commit into from
Closed

Inverted negation in if/else statement #11483

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 14, 2022

inverted negation in if/else statement
Fixes #11417

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

@publiclab/reviewers please do review and merge.

@welcome
Copy link

welcome bot commented Oct 14, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Oct 14, 2022

@codeclimate
Copy link

codeclimate bot commented Oct 14, 2022

Code Climate has analyzed commit 643246d and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8775009774/artifacts/398203166

@TildaDares
Copy link
Member

Resolved in #11484

@TildaDares TildaDares closed this Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rubocop-fix: Invert negation in if/else
1 participant