drupal_tag => tag

[ghost]

I'm back :D

Part of #956

it is failing one test, as you should see in travis. @jywarren pointers?

• all tests pass -- rake test:all
• code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
• pull request is descriptively named with #number reference back to original issue
• if possible, multiple commits squashed if they're smaller changes
• reviewed/confirmed/tested by another contributor or maintainer
• schema.rb.example has been updated if any database migrations were added

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

[jywarren]

Hi, welcome back! Great to see your work here.

I'm curious, do you have Gemfile.lock in your .gitignore file? I was wondering why its been added to your changes; just checking! We don't need it to be, I believe.

I'll go through more of this soon, thank you!

[jywarren]

Hmm, it seems to be passing, and wow, a very thorough body of work! It's rebased on top of the latest master?

We now have a staging server we can try things like this out on before going live with them. So I have more confidence in merging this. What do you think?

[ghost]

go ahead and try it on the server, sure :) If it passes on Travis and on the staging server, it must have been either on my end or specific to sqlite. As for my Gemfile.lock, I haven't edited the .gitignore

…

On Wed, Jan 11, 2017 at 3:41 AM Jeffrey Warren ***@***.***> wrote: Hmm, it seems to be passing, and wow, a very thorough body of work! It's rebased on top of the latest master? We now have a staging server we can try things like this out on before going live with them. So I have more confidence in merging this. What do you think? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1178 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOKKP2WEQCMvI6PNoY_VaZ9hiqKaolwsks5rQ97RgaJpZM4LfwHH> .

[jywarren]

Great, can you revert the changes from the Gemfile.lock and push up one more commit? Thanks!!

[ghost]

@jywarren should be all better now :)

I'll go through the rest of those #956 issues too maybe :D

[jywarren]

Merged!!! I'm going to move it to the stable branch so it can be tested out there before publishing. Thank you, amazing work!

[jywarren]

OK - it's building here, now: http://staging.laboratoriopublico.org/

Once it's done, it can be tested out here; http://testing.laboratoriopublico.org/

Give me a thumbs up after making/editing/deleting a few tags and checking out the tags pages?

Thank you!!! 🎉

[ghost]

i will tomorrow sure :) ill need to make an account and all that first but I'll let you know

…

On Wed, Jan 11, 2017 at 6:59 AM Jeffrey Warren ***@***.***> wrote: OK - it's building here, now: http://staging.laboratoriopublico.org/ Once it's done, it can be tested out here; http://testing.laboratoriopublico.org/ Give me a thumbs up after making/editing/deleting a few tags and checking out the tags pages? Thank you!!! 🎉 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1178 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOKKP-InolU3TVXRDD361urMdcgeq4Scks5rRA1ugaJpZM4LfwHH> .