initial attempt at mysql fulltext search for nodes #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icarito I'm unable to get unstable to build this and generate a new schema.rb file with |
|
ok, got it! used local mysql. |
Generated by 🚫 Danger |
|
We can later integrate this with plots2/app/services/typeahead_service.rb Line 38 in 111fda5 |
|
We'd want to later expand it to include node tags... probably in that method i just linked to. |
|
@icarito -- wow |
|
Adding a new index for revision title |
|
I think we're at the point where we need to start removing Solr infrastructure...!! @icarito |
|
like the solr tests for this typeahead feature |
This was referenced Jan 8, 2018
|
This seems ready to go except I can't get it to build on unstable due to the |
|
Tried adding SECRET_KEY_BASE and SECRET_TOKEN env variables but that didn't change anything, looking for what might have changed to need to configure this. |
|
Ah I think I know what's going on, need to pass the secret across the Dockerfile... making patch |
|
@jywarren rejiggered! |
|
Logs are showing this now: |
|
Line 127 in a876a84 Aha! It looks like the Revisions table is almost empty. Can we reload the database? |
|
Okay I loaded a db dump from september, and the app starts, but when I attempt migration it says: |
|
Whoa that was actually the mysql server crashing on migration! |
|
Perhaps the container runs out of memory when creating the index? |
|
Looks similar to this: https://stackoverflow.com/questions/17724636/adding-fulltext-index-crashes-mysql-service - looking for options - seems an instance of this bug: https://bugs.mysql.com/bug.php?id=82665 which suggests upgrading to mysql 5.7 might fix it. Also will consider MariaDB. |
|
Hey, I upgraded staging unstable branch to mariadb 10.2 and was able to create the fulltext indexes. |
|
I'll make another pull request with the database upgrade. Note this requires some manual steps when deploying to production as there are maintenance scripts to be run. Mariadb over Mysql selection to be agreed, either should work but possibly harder to switch between them after upgrade. |
|
Agree, awesome! Let's do this!!
…On Jan 12, 2018 1:56 AM, "Sebastian Silva" ***@***.***> wrote:
I'll make another pull request with the database upgrade. Note this
requires some manual steps when deploying to production as there are
maintenance scripts to be run. Mariadb over Mysql selection to be agreed,
either should work but possibly harder to switch between them after upgrade.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1913 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ53erhAduKuAMRymoho7DhLWOwkTks5tJwISgaJpZM4RST88>
.
|
|
We do check for |
|
I think this is ready for merge, to tell the truth -- as soon as the MariaDB stuff is in place. Eager!!! |
|
* Remove Solr stuff and add secret_token env var * Upgrade and switch database engine to Mariadb.
|
Tested successfully in unstable, now trying it in stable: |
|
Deployed to production! |
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* initial attempt at mysql fulltext search for nodes * tweak * major rails 4.x update of schema.rb, added fulltext index * Update node.rb * Update node_test.rb * rename * self. * add title to fulltext * plugged into typeahead * rev title fulltext index * fixed fulltext multi index * updated schema example * fix * tweaked working fulltext in console * removing solr test apparatus * full text comment and user bio searching * more conditions * fixes * unique results by grouping by nid * Remove Solr stuff and add secret_token env var (publiclab#259) * Remove Solr stuff and add secret_token env var * Upgrade and switch database engine to Mariadb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve several issues, including: