Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created LABELS.md #3981

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Created LABELS.md #3981

merged 2 commits into from
Nov 16, 2018

Conversation

oorjitchowdhary
Copy link
Member

@oorjitchowdhary oorjitchowdhary commented Nov 15, 2018

This summarizes the various labels and tags used by the organization for faster reviews and keeping the repo organized.

Fixes #2341

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

This summarizes the various labels and tags used by the organization for faster reviews and keeping the repo organized.
@oorjitchowdhary
Copy link
Member Author

@SidharthBansal @jywarren @Souravirus This is the documentation regarding labels used in the organization... Pls review... and approve my task at the gci platform... 😃

@plotsbot
Copy link
Collaborator

plotsbot commented Nov 15, 2018

1 Message
📖 @oorjitchowdhary Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren
Copy link
Member

Oh this is nice!!! Actually i think you can use a single for makingsections like this` inline. Could you make that modification? instead of ```

Copy link
Member

@SidharthBansal SidharthBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!
Well done!

@oorjitchowdhary
Copy link
Member Author

Oh this is nice!!! Actually i think you can use a single for makingsections like this` inline. Could you make that modification? instead of ```

Okay done...

@oorjitchowdhary
Copy link
Member Author

Pls merge and also approve my task at the GCI platform .. Thanks

@oorjitchowdhary
Copy link
Member Author

@avsingh999 @Souravirus

@Souravirus
Copy link
Member

Yeah really nice work @oorjitchowdhary, I will be approving this task if anyone hasn't approved this in GCI candidate. Thank you!!

@jywarren jywarren merged commit 82b794b into publiclab:master Nov 16, 2018
@ghost ghost removed the ready label Nov 16, 2018
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* Created LABELS.md

This summarizes the various labels and tags used by the organization for faster reviews and keeping the repo organized.

* Update LABELS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants