Fix "Show 0 more" on inline people lists

[jonxuxu]

Fixes #2151

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

This PR should fix the error of a toggle that says "show 0 more"

I increased the index at which toggle would appear.

I'm unable to test this on localhost as this page https://publiclab.org/w/power-tags#Inline+power+tags seems to be hosted on a database.

[plotsbot]

	1 Warning
⚠️	It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!

	2 Messages
📖	@JonathanXu1 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[SidharthBansal]

Can you please explain why was it happening?

[SidharthBansal]

Please take the task on the dashboard, and tell us the link here we will approve it if your solution works.

[jonxuxu]

plots2/app/views/grids/_people.html.erb

Lines 13 to 29 in 1d96583

	<% users.each_with_index do |user, index| %>
	<% if index > 9 %>
	<tr class="hide">
	<% else %>
	<tr>
	<% end %>
	<td class="username"><a href="/profile/<%= user.username %>"><%= user.username %></a> <%=user.new_contributor %></td>
	</tr>
	<% if index == 10 %>
	<tr class="show-all">
	<td><a>Show <%= users.length - 10 %> more <b class="caret"></b></a></td>
	<td></td>
	<td></td>
	<td></td>
	</tr>
	<% end %>
	<% end %>

As you can see on line 21, the comparative used to be <% if index == 9%>
This would cause the show X more tag to show when there on the 10th listing. However if there are only 10 listings, it would say show 0 more.

[jonxuxu]

@SidharthBansal could I get a link to the task? Don't think I can find it

[SidharthBansal]

https://codein.withgoogle.com/dashboard/tasks/4861439278841856/

…

On Mon, Dec 10, 2018 at 8:41 PM Jonathan Xu ***@***.***> wrote: @SidharthBansal <https://github.com/SidharthBansal> could I get a link to the task? Don't think I can find it — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4253 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQ6jq4jsd_KEYMw4mW3dJKAc_DqbXks5u3nmygaJpZM4ZLhHV> .

[jywarren]

Ah, but you should be able to copy the short code which generates the table into a wiki page on your own local copy. Should be something like: [people:____] -- hope that helps!

…

On Mon, Dec 10, 2018 at 8:51 AM Jonathan Xu ***@***.***> wrote: Fixes #2151 <#2151> Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks! - tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test - code is in uniquely-named feature branch and has no merge conflicts - PR is descriptively titled - ask @publiclab/reviewers for help, in a comment below This PR should fix the error of a toggle that says "show 0 more" [image: image] <https://user-images.githubusercontent.com/22998430/49739837-d6774200-fc60-11e8-9e54-0f29cee5787e.png> I increased the index at which toggle would appear. I'm unable to test this on localhost as this page https://publiclab.org/w/power-tags#Inline+power+tags seems to be hosted on a database. ------------------------------ You can view, comment on, or merge this pull request online at: #4253 Commit Summary - made field required - Merge branch 'master' of https://github.com/publiclab/plots2 - Merge branch 'master' of https://github.com/publiclab/plots2 - fix merge conflict - Merge branch 'master' of https://github.com/publiclab/plots2 - Merge branch 'master' of https://github.com/publiclab/plots2 - Merge branch 'master' of https://github.com/publiclab/plots2 - Merge branch 'master' of https://github.com/publiclab/plots2 - fix merge conflict - Merge branch 'master' of https://github.com/publiclab/plots2 - Merge branch 'master' of https://github.com/publiclab/plots2 - Merge branch 'master' of https://github.com/publiclab/plots2 - Merge branch 'master' of https://github.com/publiclab/plots2 - delete comment moderate file - Merge branch 'master' of https://github.com/publiclab/plots2 - Merge branch 'master' of https://github.com/publiclab/plots2 - fix show 0 more error File Changes - *M* app/views/grids/_people.html.erb <https://github.com/publiclab/plots2/pull/4253/files#diff-0> (4) Patch Links: - https://github.com/publiclab/plots2/pull/4253.patch - https://github.com/publiclab/plots2/pull/4253.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4253>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJwhpEp8yyZdXBUpMZOqM9ENFZx8Gks5u3nS6gaJpZM4ZLhHV> .

[SidharthBansal]

@JonathanXu1 do you need any help here?

[SidharthBansal]

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab
@jywarren @gauravano