Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in notes display #5078

Closed
wants to merge 1 commit into from
Closed

Fixed bug in notes display #5078

wants to merge 1 commit into from

Conversation

ananyaarun
Copy link
Member

@ananyaarun ananyaarun commented Mar 14, 2019

Fixes #5076

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • PR is descriptively titled 📑
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@plotsbot
Copy link
Collaborator

2 Messages
📖 @ananyaarun Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@ananyaarun
Copy link
Member Author

Oh just realized i deleted this branch thinking it was already merged :(
I shall close this and open a new PR
Thanks.

@ananyaarun ananyaarun closed this Mar 15, 2019
@ananyaarun ananyaarun mentioned this pull request Mar 15, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants