Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _tags_popover.html.erb #5187

Closed
wants to merge 1 commit into from
Closed

Conversation

shubhi2000
Copy link
Contributor

@shubhi2000 shubhi2000 commented Mar 20, 2019

Fixes #5021 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Mar 20, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
Also, can you tell us your Twitter handle so we can thank you properly?

@plotsbot
Copy link
Collaborator

2 Messages
📖 @shubhi2000 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@shubhi2000
Copy link
Contributor Author

shubhi2000 commented Mar 20, 2019 via email

@CleverFool77
Copy link
Member

Hi @shubhi2000 Both of your PR are for same issue ? #5187 #5192

@shubhi2000
Copy link
Contributor Author

shubhi2000 commented Mar 20, 2019

@CleverFool77 initially the issue referred changes in a different file, so I committed changes in it and created a PR. Then @IshaGupta18 pointed out that the wrong file was being referred there, and editted the issue. So, now I have committed changes in that file and created a PR.

@shubhi2000 shubhi2000 closed this Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants