wiki index sorting bug and styling #5326

GettyOrawo · 2019-04-01T09:03:37Z

Fixes #5317

Managed

wikis can now be sorted by any of the columns.

Peculiar

last-edited column sorts perfectly locally but doesn't seem to work in production. So I can't reproduce the bug for sorting by last-edited.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

Thanks!

plotsbot · 2019-04-01T09:17:36Z

	1 Warning
⚠️	It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!

	1 Message
📖	@GettyOrawo Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

into sort-on-wiki-page

…t-on-wiki-page

GettyOrawo · 2019-04-02T09:04:16Z

@publiclab/reviewers once the tests pass would love your reviews on this please. Thank you.

GettyOrawo · 2019-04-02T09:06:13Z

@jywarren, @gauravano the PR is ready for reviews though I can't seem to reproduce the bug for sorting by last-edited locally. It works fine on my end yet I can't tell why it breaks in production...

grvsachdeva · 2019-04-03T12:21:32Z

Hey @GettyOrawo, I am getting unsorted result for page views

Checking code now..

grvsachdeva · 2019-04-03T12:24:28Z

app/controllers/wiki_controller.rb

- order_string = 'views DESC'
- elsif sort_param == 'likes'
+ when 'page_views'
+ order_string = 'node.vid DESC'


I think here's the issue.

Thanks @gauravano , the GIF is broken so I can't see the behavior but let me give this a second look.

…t-on-wiki-page

GettyOrawo · 2019-04-04T08:56:52Z

Hey @gauravano can you try now? Seems to be working okay on my local.

GettyOrawo · 2019-04-09T08:37:16Z

Sorry, is this still pending?

alonpeer

LGTM!

jywarren · 2019-04-10T23:58:05Z

Hi all! This also looks good to me, but what is the default sorting that we fall back to? I wonder if plain /wiki is getting sorted oddly due to whatever the default sorting is?

https://publiclab.org/wiki

But I defer to @gauravano on this one. Thank you so much!!!

jywarren · 2019-04-10T23:58:30Z

And many apologies for slow response on this one! We appreciate your help!!!!

alonpeer · 2019-04-11T06:17:17Z

The default is node_revisions.timestamp which is ?order=last_edited. It makes sense to me, since it also includes recently created page, so new pages will float to the top.

grvsachdeva · 2019-04-14T16:12:46Z

It's working good in development but in production, many sorting options don't work right 😕. Try on https://unstable.publiclab.org/wiki?sort=last_edited

@jywarren @alonpeer @GettyOrawo thoughts?

alonpeer · 2019-04-14T18:25:26Z

Can you please tell me a bit more about the unstable.publiclab.org environment? Is it using the same database as production, or is it another database with the same schema but test data, or is it maybe another database with a copy of production data?
It would be much easier for me to debug this if I could have a dump of the production DB to load locally.

GettyOrawo · 2019-04-16T06:34:59Z

Yes @alonpeer and @gauravano I would also find it a lot easier to test this on unstable environment. How do I push to unstable? And do I need to be authorized.. I once tried and failed for not having rights.

grvsachdeva · 2019-04-21T15:48:17Z

Can you please tell me a bit more about the unstable.publiclab.org environment?

We use unstable to test changes. Only some people have push access but if you want to test your PR there, you can ask in Gitter channel and someone else can do it for you.

Is it using the same database as production, or is it another database with the same schema but test data, or is it maybe another database with a copy of production data?

It's another database with a copy from production data.

It would be much easier for me to debug this if I could have a dump of the production DB to load locally.

I think, it's not possible. Although, @icarito can better answer that.

SidharthBansal · 2019-05-09T19:12:15Z

How is it going here?

GettyOrawo · 2019-05-10T05:43:59Z

hey @SidharthBansal this is one of those "It works on my machine and not in production" kind of bugs. Didn't try pushing to unstable though.

SidharthBansal · 2019-07-31T14:17:52Z

Please resolve the conflicts and try to push it on unstable

SidharthBansal · 2020-04-07T21:01:14Z

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab

Styling on wikipage- remove url column

3f76a4f

GettyOrawo added 6 commits April 2, 2019 09:52

use case statements instead of if-elsif

e203e9f

Update wiki_controller.rb

2aa377b

sorting for title works

c3bb45e

pageviews sorting works

ecdfb4e

Merge branch 'sort-on-wiki-page' of https://github.com/GettyOrawo/plots2

a609a80

into sort-on-wiki-page

Merge branch 'master' of https://github.com/publiclab/plots2 into sor…

0b8d243

…t-on-wiki-page

GettyOrawo mentioned this pull request Apr 2, 2019

Wiki index ordering #5317

Open

grvsachdeva reviewed Apr 3, 2019

View reviewed changes

GettyOrawo added 2 commits April 4, 2019 11:30

Merge branch 'master' of https://github.com/publiclab/plots2 into sor…

fa12969

…t-on-wiki-page

change page views to order by node.views

ea51048

alonpeer approved these changes Apr 10, 2019

View reviewed changes

jywarren approved these changes Apr 10, 2019

View reviewed changes

GettyOrawo mentioned this pull request Apr 11, 2019

Fixes number of "wiki edits" displayed on Dashboard #5447

Closed

5 tasks

SidharthBansal closed this Apr 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wiki index sorting bug and styling #5326

wiki index sorting bug and styling #5326

GettyOrawo commented Apr 1, 2019 •

edited

Loading

plotsbot commented Apr 1, 2019 •

edited

Loading

GettyOrawo commented Apr 2, 2019

GettyOrawo commented Apr 2, 2019

grvsachdeva commented Apr 3, 2019

grvsachdeva Apr 3, 2019

GettyOrawo Apr 4, 2019

GettyOrawo commented Apr 4, 2019

GettyOrawo commented Apr 9, 2019

alonpeer left a comment

jywarren commented Apr 10, 2019

jywarren commented Apr 10, 2019

alonpeer commented Apr 11, 2019 •

edited

Loading

grvsachdeva commented Apr 14, 2019

alonpeer commented Apr 14, 2019

GettyOrawo commented Apr 16, 2019

grvsachdeva commented Apr 21, 2019 •

edited

Loading

SidharthBansal commented May 9, 2019

GettyOrawo commented May 10, 2019

SidharthBansal commented Jul 31, 2019

SidharthBansal commented Apr 7, 2020

wiki index sorting bug and styling #5326

wiki index sorting bug and styling #5326

Conversation

GettyOrawo commented Apr 1, 2019 • edited Loading

plotsbot commented Apr 1, 2019 • edited Loading

GettyOrawo commented Apr 2, 2019

GettyOrawo commented Apr 2, 2019

grvsachdeva commented Apr 3, 2019

grvsachdeva Apr 3, 2019

Choose a reason for hiding this comment

GettyOrawo Apr 4, 2019

Choose a reason for hiding this comment

GettyOrawo commented Apr 4, 2019

GettyOrawo commented Apr 9, 2019

alonpeer left a comment

Choose a reason for hiding this comment

jywarren commented Apr 10, 2019

jywarren commented Apr 10, 2019

alonpeer commented Apr 11, 2019 • edited Loading

grvsachdeva commented Apr 14, 2019

alonpeer commented Apr 14, 2019

GettyOrawo commented Apr 16, 2019

grvsachdeva commented Apr 21, 2019 • edited Loading

SidharthBansal commented May 9, 2019

GettyOrawo commented May 10, 2019

SidharthBansal commented Jul 31, 2019

SidharthBansal commented Apr 7, 2020

GettyOrawo commented Apr 1, 2019 •

edited

Loading

plotsbot commented Apr 1, 2019 •

edited

Loading

alonpeer commented Apr 11, 2019 •

edited

Loading

grvsachdeva commented Apr 21, 2019 •

edited

Loading