remove answer notification code #5496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
ViditChitkara
force-pushed
the
answer-notification-deprication
branch
from
afc3267 to
ddbea13
Compare
|
Looks good; we resolved an upstream test failure today so perhaps this just needs a rebase? Not sure, though! Thanks!!!! |
ViditChitkara
force-pushed
the
answer-notification-deprication
branch
from
e1ab6bc to
a246f7b
Compare
|
@publiclab/reviewers , @jywarren , @jainaman224 I think this is ready to merge. Kindly have a look. |
jywarren
reviewed
May 31, 2019
jainaman224
reviewed
May 31, 2019
| @@ -11,8 +11,7 @@ def likes | |||
| AnswerSelection.set_likes(current_user.uid, @answer.id, false) | |||
| else | |||
| AnswerSelection.set_likes(current_user.uid, @answer.id, true) | |||
| user = User.find(current_user.uid) | |||
| AnswerMailer.notify_answer_like(user, @answer).deliver_later | |||
| User.find(current_user.uid) | |||
There was a problem hiding this comment.
I think this is not required. We already have user as current_user.
😄
There was a problem hiding this comment.
Yeah, I think that line didn't make any sense. Thanks for pointing out!!
Woah, I think that was added by mistake. Removed it. |
ViditChitkara
force-pushed
the
answer-notification-deprication
branch
from
b3bb9af to
402552b
Compare
|
Looks good!!!! Thank you!!! |
enviro3
pushed a commit
to enviro3/plots2
that referenced
this pull request
Aug 15, 2019
* remove answer notification code * minor changes * fix answer tests * minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4094