Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

narrow content_followed_in_period to notes by default #5568

Merged
merged 4 commits into from
Apr 22, 2019
Merged

narrow content_followed_in_period to notes by default #5568

merged 4 commits into from
Apr 22, 2019

Conversation

jywarren
Copy link
Member

Re: #4732

@jywarren jywarren mentioned this pull request Apr 21, 2019
Closed
9 tasks
@plotsbot
Copy link
Collaborator

plotsbot commented Apr 21, 2019 •
edited
Loading

1 Message
📖 @jywarren Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren
Copy link
Member Author

Good, we're filtering out one item!

 FAIL["test_returns_nodes_created_in_given_period_of_time", #<Minitest::Reporters::Suite:0x0000558f8ab97980 @name="UserTest">, 150.46908899099992]
 test_returns_nodes_created_in_given_period_of_time#UserTest (150.47s)
        Expected: 5
          Actual: 4
        test/unit/user_test.rb:124:in `block in <class:UserTest>'

@jywarren jywarren merged commit d893c51 into master Apr 22, 2019
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@jywarren
narrow content_followed_in_period to notes by default (publiclab#5568)
12d4f24 
* narrow content_followed_in_period to notes by default

* Update user_test.rb

* Update user.rb

* Update user_test.rb
digitaldina pushed a commit to digitaldina/plots2 that referenced this pull request May 12, 2019
@jywarren @digitaldina
narrow content_followed_in_period to notes by default (publiclab#5568)
1d7d22f 
* narrow content_followed_in_period to notes by default

* Update user_test.rb

* Update user.rb

* Update user_test.rb
@cesswairimu cesswairimu deleted the notes_in_period-1 branch May 4, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jywarren @plotsbot