-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
further refactoring or answers #5883
Merged
jywarren
merged 3 commits into
publiclab:master
from
ViditChitkara:answer-code-refactor
Jun 13, 2019
Merged
further refactoring or answers #5883
jywarren
merged 3 commits into
publiclab:master
from
ViditChitkara:answer-code-refactor
Jun 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still some refactoring left. working on that. |
Screenshots 📸 (click to expand)Learn about automated screenshots Generated by 🚫 Danger |
I think this is ready to go now!! @jywarren |
Most of the refactoring is done. Just bits and pieces left! |
jywarren
approved these changes
Jun 13, 2019
rarrunategu1
pushed a commit
to rarrunategu1/plots2
that referenced
this pull request
Jun 14, 2019
* further refactoring or answers * remove some answer partials * further changes
sagarpreet-chadha
pushed a commit
that referenced
this pull request
Jun 29, 2019
* further refactoring or answers * remove some answer partials * further changes
enviro3
pushed a commit
to enviro3/plots2
that referenced
this pull request
Aug 15, 2019
* further refactoring or answers * remove some answer partials * further changes
enviro3
pushed a commit
to enviro3/plots2
that referenced
this pull request
Aug 15, 2019
* further refactoring or answers * remove some answer partials * further changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #4094