Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further refactoring or answers #5883

Merged
merged 3 commits into from
Jun 13, 2019

Conversation

ViditChitkara
Copy link
Member

part of #4094

@ViditChitkara
Copy link
Member Author

Still some refactoring left. working on that.

@plotsbot
Copy link
Collaborator

plotsbot commented Jun 12, 2019

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
2 Messages
📖 @ViditChitkara Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 #
Screenshots 📸 (click to expand)

Learn about automated screenshots

Generated by 🚫 Danger

@ViditChitkara
Copy link
Member Author

I think this is ready to go now!! @jywarren

@ViditChitkara
Copy link
Member Author

Most of the refactoring is done. Just bits and pieces left!

@jywarren jywarren merged commit f472017 into publiclab:master Jun 13, 2019
rarrunategu1 pushed a commit to rarrunategu1/plots2 that referenced this pull request Jun 14, 2019
* further refactoring or answers

* remove some answer partials

* further changes
sagarpreet-chadha pushed a commit that referenced this pull request Jun 29, 2019
* further refactoring or answers

* remove some answer partials

* further changes
enviro3 pushed a commit to enviro3/plots2 that referenced this pull request Aug 15, 2019
* further refactoring or answers

* remove some answer partials

* further changes
enviro3 pushed a commit to enviro3/plots2 that referenced this pull request Aug 15, 2019
* further refactoring or answers

* remove some answer partials

* further changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants